Merge pull request #153 from jamesgeorge007/patch-1

chore: minor code refactor
This commit is contained in:
Liyas Thomas
2019-09-18 15:39:30 +05:30
committed by GitHub
3 changed files with 5 additions and 5 deletions

View File

@@ -40,7 +40,7 @@ function parseCurlCommand(curlCommand) {
if (!url) {
for (let argName in parsedArguments) {
if (typeof parsedArguments[argName] === 'string') {
if (parsedArguments[argName].indexOf('http') === 0 || parsedArguments[argName].indexOf('www.') === 0) {
if (['http', 'www.'].includes(parsedArguments[argName])) {
url = parsedArguments[argName];
}
}
@@ -57,7 +57,7 @@ function parseCurlCommand(curlCommand) {
parsedArguments[headerFieldName] = [parsedArguments[headerFieldName]];
}
parsedArguments[headerFieldName].forEach(function(header) {
if (header.indexOf('Cookie') !== -1) {
if (header.includes('Cookie')) {
// stupid javascript tricks: closure
cookieString = header;
} else {
@@ -149,7 +149,7 @@ function parseCurlCommand(curlCommand) {
if (option) {
let urlQueryString = '';
if (url.indexOf('?') < 0) {
if (!url.includes('?')) {
url += '?';
} else {
urlQueryString += '&';

View File

@@ -39,7 +39,7 @@ try {
runCommand("git", ["branch"])
.split("* ")[1]
.split(" ")[0] + (IS_DEV_MODE ? " - DEV MODE" : "");
if (version.variant === "" || version.variant === "master")
if (["", "master"].includes(version.variant))
delete version.variant;
// Write version data into a file

View File

@@ -517,7 +517,7 @@
value
}) => `${key}=${value}`).join('&')
queryString = queryString === '' ? '' : `?${queryString}`
if(path.indexOf('?') !== -1) {
if(path.includes('?')) {
path = path.slice(0, path.indexOf('?')) + queryString;
} else {
path = path + queryString