btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Use built in log instead of creating a new array

Browse Source
This commit is contained in:
David Reid
2020-04-30 01:41:22 -05:00
parent 83b1993cd2
commit 76082a2e61
1 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
components/realtime/websocket.vue
View File

@@ -81,9 +81,8 @@ export default {
communication: { communication: {
log: null, log: null,
input: "", input: "",
messageHistory: [],
currentIndex: -1, //index of the messageHistory array to put in input box
}, },
currentIndex: -1, //index of the message log array to put in input box
} }
}, },
computed: { computed: {
@@ -179,30 +178,23 @@ export default {
source: "client", source: "client",
ts: new Date().toLocaleTimeString(), ts: new Date().toLocaleTimeString(),
}) })
//push message to history array and resets the currentIndex
if (
this.communication.messageHistory[this.communication.messageHistory.length - 1] !== message
) {
this.communication.messageHistory.push(message)
this.currentIndex = -1
}
this.communication.input = "" this.communication.input = ""
}, },
walkHistory(direction) { walkHistory(direction) {
const length = this.communication.messageHistory.length const clientMessages = this.communication.log.filter((msg) => msg.source === "client")
const length = clientMessages.length
switch (direction) { switch (direction) {
case "up": case "up":
if (length > 0 && this.currentIndex !== 0) { if (length > 0 && this.currentIndex !== 0) {
//does nothing if messageHistory is empty or the currentIndex is 0 when up arrow is pressed //does nothing if message log is empty or the currentIndex is 0 when up arrow is pressed
if (this.currentIndex === -1) { if (this.currentIndex === -1) {
this.currentIndex = length - 1 this.currentIndex = length - 1
this.communication.input = this.communication.messageHistory[this.currentIndex] this.communication.input = clientMessages[this.currentIndex].payload
} else if (this.currentIndex === 0) { } else if (this.currentIndex === 0) {
this.communication.input = this.communication.messageHistory[0] this.communication.input = clientMessages[0].payload
} else if (this.currentIndex > 0) { } else if (this.currentIndex > 0) {
this.currentIndex = this.currentIndex - 1 this.currentIndex = this.currentIndex - 1
this.communication.input = this.communication.messageHistory[this.currentIndex] this.communication.input = clientMessages[this.currentIndex].payload
} }
} }
break break
@@ -213,7 +205,7 @@ export default {
this.communication.input = "" this.communication.input = ""
} else if (this.currentIndex < length - 1) { } else if (this.currentIndex < length - 1) {
this.currentIndex = this.currentIndex + 1 this.currentIndex = this.currentIndex + 1
this.communication.input = this.communication.messageHistory[this.currentIndex] this.communication.input = clientMessages[this.currentIndex].payload
} }
} }
break break