From 4c82ef89fbcb71376d9209747146963574c18506 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 18:52:34 +0530 Subject: [PATCH 01/16] refactor: make component tag self closing --- pages/index.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/index.vue b/pages/index.vue index 5a2ba82bd..808e14117 100644 --- a/pages/index.vue +++ b/pages/index.vue @@ -701,7 +701,7 @@ v-bind:show="showRequestModal" v-on:hide-model="hideRequestModal" v-bind:editing-request="editRequest" - > + />
From fcc6f5aa76895422a1ca18d0c0509467dd9a9f3a Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 18:55:29 +0530 Subject: [PATCH 02/16] refactor: make history component self closing --- pages/index.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/index.vue b/pages/index.vue index 808e14117..d02d9e916 100644 --- a/pages/index.vue +++ b/pages/index.vue @@ -685,7 +685,7 @@ + />
From 82096f3a1eb53157dd836e7d6462a74daaa24189 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 18:59:45 +0530 Subject: [PATCH 03/16] refactor: use property shorthand for consistency --- components/collections/index.vue | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/components/collections/index.vue b/components/collections/index.vue index fa34f01d0..303777dfa 100644 --- a/components/collections/index.vue +++ b/components/collections/index.vue @@ -7,19 +7,19 @@ TODO:
@@ -80,10 +80,10 @@ TODO:
  • From b20cb040b084d621034008274c5474d54a6e0c9e Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 19:00:31 +0530 Subject: [PATCH 04/16] refactor: make collection component self closing --- components/collections/index.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/collections/index.vue b/components/collections/index.vue index 303777dfa..16f9f8809 100644 --- a/components/collections/index.vue +++ b/components/collections/index.vue @@ -84,7 +84,7 @@ TODO: @add-folder="addFolder(collection, index)" @edit-folder="editFolder($event)" @edit-request="editRequest($event)" - > + />
  • From f49bfb4d74ebb41f5fafb62ad0cae52f53b6d15a Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 19:01:31 +0530 Subject: [PATCH 05/16] refactor: use property shorthand for consistency --- components/collections/collection.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/collections/collection.vue b/components/collections/collection.vue index 67d08a59b..71f634c29 100644 --- a/components/collections/collection.vue +++ b/components/collections/collection.vue @@ -47,8 +47,8 @@ v-bind:folder="folder" v-bind:folderIndex="index" v-bind:collection-index="collectionIndex" - v-on:edit-folder="editFolder(collectionIndex, folder, index)" - v-on:edit-request="$emit('edit-request', $event)" + @edit-folder="editFolder(collectionIndex, folder, index)" + @edit-request="$emit('edit-request', $event)" />
  • Date: Sun, 15 Dec 2019 19:02:03 +0530 Subject: [PATCH 06/16] refactor: make request component self closing --- components/collections/collection.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/collections/collection.vue b/components/collections/collection.vue index 71f634c29..42da2b37c 100644 --- a/components/collections/collection.vue +++ b/components/collections/collection.vue @@ -74,7 +74,7 @@ requestIndex: index }) " - > + />
  • From 9223044967625fc8ea523b9a1c0a7ef11dfa1a6b Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 19:02:37 +0530 Subject: [PATCH 07/16] refactor: use property shorthand for consistency --- components/collections/folder.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/collections/folder.vue b/components/collections/folder.vue index 03a9a9e4c..ece836375 100644 --- a/components/collections/folder.vue +++ b/components/collections/folder.vue @@ -38,7 +38,7 @@ v-bind:collection-index="collectionIndex" v-bind:folder-index="folderIndex" v-bind:request-index="index" - v-on:edit-request=" + @edit-request=" $emit('edit-request', { request, collectionIndex, From 0791d196d44de936be9e553fe33acbe051fc9baa Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 19:03:18 +0530 Subject: [PATCH 08/16] refactor: use property shorthand for consistency --- pages/index.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/index.vue b/pages/index.vue index d02d9e916..9326fad56 100644 --- a/pages/index.vue +++ b/pages/index.vue @@ -699,7 +699,7 @@ From 928ace5ba67614ef48bd53f48eb87acdb0ed7cb4 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 19:03:39 +0530 Subject: [PATCH 09/16] refactor: use property shorthand for consistency --- pages/index.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pages/index.vue b/pages/index.vue index 9326fad56..e700927b8 100644 --- a/pages/index.vue +++ b/pages/index.vue @@ -698,9 +698,9 @@ From 48bd772171b1a6c51689ef11d2bf2bcdeac87161 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 15 Dec 2019 19:13:53 +0530 Subject: [PATCH 10/16] refactor: make use of v-bind directive shorthand vue.js best practices --- components/collections/index.vue | 40 ++++++++++++++++---------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/components/collections/index.vue b/components/collections/index.vue index 16f9f8809..ec7a1cef2 100644 --- a/components/collections/index.vue +++ b/components/collections/index.vue @@ -6,39 +6,39 @@ TODO: