feat: remove authName from HoppRESTAuth type definitions

This commit is contained in:
Andrew Bastin
2021-08-22 13:06:19 +05:30
parent 22e73a4d83
commit 1a4fc1f539
5 changed files with 11 additions and 20 deletions

View File

@@ -36,7 +36,6 @@
label="None"
@click.native="
authType = 'none'
authName = 'None'
$refs.authTypeOptions.tippy().hide()
"
/>
@@ -44,7 +43,6 @@
label="Basic Auth"
@click.native="
authType = 'basic'
authName = 'Basic Auth'
$refs.authTypeOptions.tippy().hide()
"
/>
@@ -52,7 +50,6 @@
label="Bearer Token"
@click.native="
authType = 'bearer'
authName = 'Bearer Token'
$refs.authTypeOptions.tippy().hide()
"
/>
@@ -174,7 +171,7 @@
</template>
<script lang="ts">
import { defineComponent, Ref, ref } from "@nuxtjs/composition-api"
import { computed, defineComponent, Ref, ref } from "@nuxtjs/composition-api"
import {
HoppRESTAuthBasic,
HoppRESTAuthBearer,
@@ -187,12 +184,16 @@ export default defineComponent({
setup() {
const auth = useStream(
restAuth$,
{ authType: "none", authName: "None", authActive: true },
{ authType: "none", authActive: true },
setRESTAuth
)
const authType = pluckRef(auth, "authType")
const authName = pluckRef(auth, "authName")
const authName = computed(() => {
if (authType.value === "basic") return "Basic Auth"
else if (authType.value === "bearer") return "Bearer"
else return "None"
})
const authActive = pluckRef(auth, "authActive")
const basicUsername = pluckRef(auth as Ref<HoppRESTAuthBasic>, "username")
@@ -207,7 +208,6 @@ export default defineComponent({
const clearContent = () => {
auth.value = {
authType: "none",
authName: "None",
authActive: true,
}
}

View File

@@ -116,7 +116,6 @@ export default defineComponent({
testScript: "",
auth: {
authType: "none",
authName: "None",
authActive: true,
},
body: {

View File

@@ -1,13 +1,9 @@
export type HoppRESTAuthNone = {
authType: "none"
authName: "None"
authActive: true
}
export type HoppRESTAuthBasic = {
authType: "basic"
authName: "Basic Auth"
authActive: true
username: string
password: string
@@ -15,13 +11,13 @@ export type HoppRESTAuthBasic = {
export type HoppRESTAuthBearer = {
authType: "bearer"
authName: "Bearer Token"
authActive: true
token: string
}
export type HoppRESTAuth =
{ authActive: boolean } & (
| HoppRESTAuthNone
| HoppRESTAuthBasic
| HoppRESTAuthBearer
)

View File

@@ -124,14 +124,12 @@ export function parseOldAuth(x: any): HoppRESTAuth {
if (!x.auth || x.auth === "None")
return {
authType: "none",
authName: "None",
authActive: true,
}
if (x.auth === "Basic Auth")
return {
authType: "basic",
authName: "Basic Auth",
authActive: true,
username: x.httpUser,
password: x.httpPassword,
@@ -140,10 +138,9 @@ export function parseOldAuth(x: any): HoppRESTAuth {
if (x.auth === "Bearer Token")
return {
authType: "bearer",
authName: "Bearer Token",
authActive: true,
token: x.bearerToken,
}
return { authType: "none", authName: "None", authActive: true }
return { authType: "none", authActive: true }
}

View File

@@ -23,7 +23,7 @@ type RESTSession = {
saveContext: HoppRequestSaveContext | null
}
const defaultRESTRequest: HoppRESTRequest = {
export const defaultRESTRequest: HoppRESTRequest = {
v: RESTReqSchemaVersion,
endpoint: "https://echo.hoppscotch.io",
name: "Untitled request",
@@ -32,7 +32,6 @@ const defaultRESTRequest: HoppRESTRequest = {
method: "GET",
auth: {
authType: "none",
authName: "None",
authActive: true,
},
preRequestScript: "",