btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

route navigation no longer happening in typable areas (#1862)

Browse Source
This commit is contained in:
Rishabh kalra
2021-10-09 06:45:17 +05:30
committed by GitHub
parent 47b341d50e
commit 0394deaeef
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/hoppscotch-app/helpers/keybindings.ts
View File

@@ -95,9 +95,8 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null {
const modifierKey = getActiveModifier(ev) const modifierKey = getActiveModifier(ev)
const target = ev.target const target = ev.target
// override default behaviour if element is typable
if (!modifierKey && !(isDOMElement(target) && isTypableElement(target))) { if (modifierKey && isDOMElement(target) && isTypableElement(target)) {
// Check if we are having singulars instead
const key = getPressedKey(ev) const key = getPressedKey(ev)
if (!key) return null if (!key) return null
@@ -112,7 +111,6 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null {
function getPressedKey(ev: KeyboardEvent): Key | null { function getPressedKey(ev: KeyboardEvent): Key | null {
const val = ev.key.toLowerCase() const val = ev.key.toLowerCase()
// Check arrow keys // Check arrow keys
if (val === "arrowup") return "up" if (val === "arrowup") return "up"
else if (val === "arrowdown") return "down" else if (val === "arrowdown") return "down"