From 0394deaeef13080939a7b99ad7db35f3ac04e4df Mon Sep 17 00:00:00 2001 From: Rishabh kalra Date: Sat, 9 Oct 2021 06:45:17 +0530 Subject: [PATCH] route navigation no longer happening in typable areas (#1862) --- packages/hoppscotch-app/helpers/keybindings.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/hoppscotch-app/helpers/keybindings.ts b/packages/hoppscotch-app/helpers/keybindings.ts index 7fd06bee9..e7426c802 100644 --- a/packages/hoppscotch-app/helpers/keybindings.ts +++ b/packages/hoppscotch-app/helpers/keybindings.ts @@ -95,9 +95,8 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null { const modifierKey = getActiveModifier(ev) const target = ev.target - - if (!modifierKey && !(isDOMElement(target) && isTypableElement(target))) { - // Check if we are having singulars instead + // override default behaviour if element is typable + if (modifierKey && isDOMElement(target) && isTypableElement(target)) { const key = getPressedKey(ev) if (!key) return null @@ -112,7 +111,6 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null { function getPressedKey(ev: KeyboardEvent): Key | null { const val = ev.key.toLowerCase() - // Check arrow keys if (val === "arrowup") return "up" else if (val === "arrowdown") return "down"