Compare commits

...

3 Commits

Author SHA1 Message Date
Balu Babu
5d05518024 chore: updated testcase for findUserByEmail in user module 2024-05-14 12:02:16 +05:30
mirarifhasan
480a5f1f79 test: fix broken test case 2024-05-14 12:05:22 +06:00
mirarifhasan
6f23667c9c feat: code level email insensitivity added 2024-05-14 11:40:37 +06:00
6 changed files with 34 additions and 20 deletions

View File

@@ -121,6 +121,7 @@ describe('AdminService', () => {
NOT: { NOT: {
inviteeEmail: { inviteeEmail: {
in: [dbAdminUsers[0].email], in: [dbAdminUsers[0].email],
mode: 'insensitive',
}, },
}, },
}, },
@@ -229,7 +230,10 @@ describe('AdminService', () => {
expect(mockPrisma.invitedUsers.deleteMany).toHaveBeenCalledWith({ expect(mockPrisma.invitedUsers.deleteMany).toHaveBeenCalledWith({
where: { where: {
inviteeEmail: { in: [invitedUsers[0].inviteeEmail] }, inviteeEmail: {
in: [invitedUsers[0].inviteeEmail],
mode: 'insensitive',
},
}, },
}); });
expect(result).toEqualRight(true); expect(result).toEqualRight(true);

View File

@@ -89,12 +89,17 @@ export class AdminService {
adminEmail: string, adminEmail: string,
inviteeEmail: string, inviteeEmail: string,
) { ) {
if (inviteeEmail == adminEmail) return E.left(DUPLICATE_EMAIL); if (inviteeEmail.toLowerCase() == adminEmail.toLowerCase()) {
return E.left(DUPLICATE_EMAIL);
}
if (!validateEmail(inviteeEmail)) return E.left(INVALID_EMAIL); if (!validateEmail(inviteeEmail)) return E.left(INVALID_EMAIL);
const alreadyInvitedUser = await this.prisma.invitedUsers.findFirst({ const alreadyInvitedUser = await this.prisma.invitedUsers.findFirst({
where: { where: {
inviteeEmail: inviteeEmail, inviteeEmail: {
equals: inviteeEmail,
mode: 'insensitive',
},
}, },
}); });
if (alreadyInvitedUser != null) return E.left(USER_ALREADY_INVITED); if (alreadyInvitedUser != null) return E.left(USER_ALREADY_INVITED);
@@ -159,7 +164,7 @@ export class AdminService {
try { try {
await this.prisma.invitedUsers.deleteMany({ await this.prisma.invitedUsers.deleteMany({
where: { where: {
inviteeEmail: { in: inviteeEmails }, inviteeEmail: { in: inviteeEmails, mode: 'insensitive' },
}, },
}); });
return E.right(true); return E.right(true);
@@ -189,6 +194,7 @@ export class AdminService {
NOT: { NOT: {
inviteeEmail: { inviteeEmail: {
in: userEmailObjs.map((user) => user.email), in: userEmailObjs.map((user) => user.email),
mode: 'insensitive',
}, },
}, },
}, },

View File

@@ -299,7 +299,10 @@ export class ShortcodeService implements UserDataHandler, OnModuleInit {
where: userEmail where: userEmail
? { ? {
User: { User: {
email: userEmail, email: {
equals: userEmail,
mode: 'insensitive',
},
}, },
} }
: undefined, : undefined,

View File

@@ -75,12 +75,13 @@ export class TeamInvitationService {
if (!isEmailValid) return E.left(INVALID_EMAIL); if (!isEmailValid) return E.left(INVALID_EMAIL);
try { try {
const teamInvite = await this.prisma.teamInvitation.findUniqueOrThrow({ const teamInvite = await this.prisma.teamInvitation.findFirstOrThrow({
where: { where: {
teamID_inviteeEmail: { inviteeEmail: {
inviteeEmail: inviteeEmail, equals: inviteeEmail,
teamID: teamID, mode: 'insensitive',
}, },
teamID,
}, },
}); });

View File

@@ -149,7 +149,7 @@ beforeEach(() => {
describe('UserService', () => { describe('UserService', () => {
describe('findUserByEmail', () => { describe('findUserByEmail', () => {
test('should successfully return a valid user given a valid email', async () => { test('should successfully return a valid user given a valid email', async () => {
mockPrisma.user.findUniqueOrThrow.mockResolvedValueOnce(user); mockPrisma.user.findFirst.mockResolvedValueOnce(user);
const result = await userService.findUserByEmail( const result = await userService.findUserByEmail(
'dwight@dundermifflin.com', 'dwight@dundermifflin.com',
@@ -158,7 +158,7 @@ describe('UserService', () => {
}); });
test('should return a null user given a invalid email', async () => { test('should return a null user given a invalid email', async () => {
mockPrisma.user.findUniqueOrThrow.mockRejectedValueOnce('NotFoundError'); mockPrisma.user.findFirst.mockResolvedValueOnce(null);
const result = await userService.findUserByEmail('jim@dundermifflin.com'); const result = await userService.findUserByEmail('jim@dundermifflin.com');
expect(result).resolves.toBeNone; expect(result).resolves.toBeNone;

View File

@@ -62,16 +62,16 @@ export class UserService {
* @returns Option of found User * @returns Option of found User
*/ */
async findUserByEmail(email: string): Promise<O.None | O.Some<AuthUser>> { async findUserByEmail(email: string): Promise<O.None | O.Some<AuthUser>> {
try { const user = await this.prisma.user.findFirst({
const user = await this.prisma.user.findUniqueOrThrow({ where: {
where: { email: {
email: email, equals: email,
mode: 'insensitive',
}, },
}); },
return O.some(user); });
} catch (error) { if (!user) return O.none;
return O.none; return O.some(user);
}
} }
/** /**