btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

fix: all unit test cases for backend modules (HBE-171) (#51)

Browse Source 
* fix: if-condition for getCollectionOfRequest func

* fix: all test cases for team request module

* fix: user collection test case

* fix: team module test case

* refactor: updated test description for last implemented changes in admin and removed commented code

---------

Co-authored-by: ankitsridhar16 <ankit.sridhar16@gmail.com>
This commit is contained in:
Mir Arif Hasan
2023-04-06 20:23:04 +06:00
committed by GitHub
parent 6cb3a2de43
commit ffc08227dd
7 changed files with 56 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/hoppscotch-backend/src/team-request/team-request.service.spec.ts
View File

@@ -8,6 +8,7 @@ import {
TEAM_INVALID_ID,
TEAM_REQ_NOT_FOUND,
TEAM_REQ_REORDERING_FAILED,
TEAM_COLL_NOT_FOUND,
} from 'src/errors';
import * as E from 'fp-ts/Either';
import { mockDeep, mockReset } from 'jest-mock-extended';
@@ -42,6 +43,9 @@ const teamCollection: DbTeamCollection = {
parentID: null,
teamID: team.id,
title: 'Team Collection 1',
orderIndex: 1,
createdOn: new Date(),
updatedOn: new Date(),
};
const dbTeamRequests: DbTeamRequest[] = [];
for (let i = 1; i <= 10; i++) {
@@ -236,7 +240,7 @@ describe('deleteTeamRequest', () => {
describe('createTeamRequest', () => {
test('rejects for invalid collection id', async () => {
mockTeamCollectionService.getTeamOfCollection.mockResolvedValue(null);
mockTeamCollectionService.getTeamOfCollection.mockResolvedValue(E.left(TEAM_INVALID_COLL_ID));
const response = await teamRequestService.createTeamRequest(
'invalidcollid',
@@ -253,7 +257,9 @@ describe('createTeamRequest', () => {
const dbRequest = dbTeamRequests[0];
const teamRequest = teamRequests[0];
mockTeamCollectionService.getTeamOfCollection.mockResolvedValue(team);
mockTeamCollectionService.getTeamOfCollection.mockResolvedValue(
E.right(team),
);
mockPrisma.teamRequest.create.mockResolvedValue(dbRequest);
const response = teamRequestService.createTeamRequest(
@@ -270,7 +276,9 @@ describe('createTeamRequest', () => {
const dbRequest = dbTeamRequests[0];
const teamRequest = teamRequests[0];
mockTeamCollectionService.getTeamOfCollection.mockResolvedValue(team);
mockTeamCollectionService.getTeamOfCollection.mockResolvedValue(
E.right(team),
);
mockPrisma.teamRequest.create.mockResolvedValue(dbRequest);
await teamRequestService.createTeamRequest(
@@ -359,7 +367,9 @@ describe('getTeamOfRequest', () => {
describe('getCollectionOfRequest', () => {
test('rejects for invalid collection id', async () => {
mockTeamCollectionService.getCollection.mockResolvedValue(null as any);
mockTeamCollectionService.getCollection.mockResolvedValue(
E.left(TEAM_COLL_NOT_FOUND),
);
expect(
teamRequestService.getCollectionOfRequest(teamRequests[0]),
@@ -367,7 +377,9 @@ describe('getCollectionOfRequest', () => {
});
test('resolves for valid collection id', async () => {
mockTeamCollectionService.getCollection.mockResolvedValue(teamCollection);
mockTeamCollectionService.getCollection.mockResolvedValue(
E.right(teamCollection),
);
expect(
teamRequestService.getCollectionOfRequest(teamRequests[0]),

4
packages/hoppscotch-backend/src/team-request/team-request.service.ts
View File

@@ -231,8 +231,8 @@ export class TeamRequestService {
const teamCollection = await this.teamCollectionService.getCollection(
req.collectionID,
);
if (!teamCollection) return E.left(TEAM_INVALID_COLL_ID);
return E.right(teamCollection);
if (E.isLeft(teamCollection)) return E.left(TEAM_INVALID_COLL_ID);
return E.right(teamCollection.right);
}
/**