btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

fix: codemirror crashing due to cursor not updating (#4151)

Browse Source 
fix: cursor not updating while filtering
This commit is contained in:
Nivedin
2024-07-02 13:41:20 +05:30
committed by GitHub
parent 2917d50c6a
commit fe79c47d1f
2 changed files with 7 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue
View File

@@ -307,8 +307,8 @@ const jsonResponseBodyText = computed(() => {
() => () =>
JSONPath({ JSONPath({
path: filterQueryText.value, path: filterQueryText.value,
json: parsedJSON, json: parsedJSON as any,
}) as undefined, }),
(err): BodyParseError => ({ (err): BodyParseError => ({
type: "JSON_PATH_QUERY_FAILED", type: "JSON_PATH_QUERY_FAILED",
error: err as Error, error: err as Error,

7
packages/hoppscotch-common/src/composables/codemirror.ts
View File

@@ -297,7 +297,6 @@ export function useCodemirror(
options.onUpdate(update) options.onUpdate(update)
} }
if (update.selectionSet) {
const cursorPos = update.state.selection.main.head const cursorPos = update.state.selection.main.head
const line = update.state.doc.lineAt(cursorPos) const line = update.state.doc.lineAt(cursorPos)
@@ -310,12 +309,6 @@ export function useCodemirror(
line: cachedCursor.value.line, line: cachedCursor.value.line,
ch: cachedCursor.value.ch, ch: cachedCursor.value.ch,
} }
}
cursor.value = {
line: cachedCursor.value.line,
ch: cachedCursor.value.ch,
}
if (update.docChanged) { if (update.docChanged) {
// Expensive on big files ? // Expensive on big files ?