btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

fix: improvement for body tab and RawBody empty string bug (#4273)

Browse Source 
* feat(body-label): added label that showing tab is not empty

* fix(body-raw): value is not updated when was empty

---------

Co-authored-by: Dmitry Mukovkin <d.mukovkin@cft.ru>
This commit is contained in:
Dmitry
2024-08-19 17:12:35 +07:00
committed by GitHub
parent d15e809dcb
commit f1cb417a5e
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/hoppscotch-common/src/components/http/RawBody.vue
View File

@@ -143,7 +143,7 @@ watch(rawParamsBody, (newVal) => {
// propagate the edits from codemirror back to the body // propagate the edits from codemirror back to the body
watch(codemirrorValue, (updatedValue) => { watch(codemirrorValue, (updatedValue) => {
if (updatedValue && updatedValue !== rawParamsBody.value) { if (updatedValue !== undefined && updatedValue !== rawParamsBody.value) {
rawParamsBody.value = updatedValue rawParamsBody.value = updatedValue
} }
}) })

5
packages/hoppscotch-common/src/components/http/RequestOptions.vue
View File

@@ -16,6 +16,7 @@
v-if="properties?.includes('bodyParams') ?? true" v-if="properties?.includes('bodyParams') ?? true"
:id="'bodyParams'" :id="'bodyParams'"
:label="`${t('tab.body')}`" :label="`${t('tab.body')}`"
:indicator="isBodyFilled"
> >
<HttpBody <HttpBody
v-model:headers="request.headers" v-model:headers="request.headers"
@@ -154,6 +155,10 @@ const newActiveRequestVariablesCount = computed(() => {
return count ? count : null return count ? count : null
}) })
const isBodyFilled = computed(() => {
return Boolean(request.value.body.body && request.value.body.body.length > 0)
})
defineActionHandler("request.open-tab", ({ tab }) => { defineActionHandler("request.open-tab", ({ tab }) => {
selectedOptionTab.value = tab as RESTOptionTabs selectedOptionTab.value = tab as RESTOptionTabs
}) })