From 908d672cf23dceb8f6e09bd9dc20c84e05e63c25 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sat, 11 Jan 2020 10:42:08 +0530 Subject: [PATCH 1/4] refactor: use const --- assets/js/oauth.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/js/oauth.js b/assets/js/oauth.js index 10f584ef1..927f6d0a4 100644 --- a/assets/js/oauth.js +++ b/assets/js/oauth.js @@ -5,7 +5,7 @@ const redirectUri = `${window.location.origin}/`; // Make a POST request and parse the response as JSON const sendPostRequest = async (url, params) => { - let body = Object.keys(params) + const body = Object.keys(params) .map(key => `${key}=${params[key]}`) .join("&"); const options = { From 086b2de5059890dd19050ef7cea6d9ddfe64ffb9 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sat, 11 Jan 2020 10:44:07 +0530 Subject: [PATCH 2/4] refactor: use const --- assets/js/oauth.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/js/oauth.js b/assets/js/oauth.js index 927f6d0a4..9c57bfd34 100644 --- a/assets/js/oauth.js +++ b/assets/js/oauth.js @@ -29,8 +29,8 @@ const parseQueryString = string => { if (string === "") { return {}; } - let segments = string.split("&").map(s => s.split("=")); - let queryString = {}; + const segments = string.split("&").map(s => s.split("=")); + const queryString = {}; segments.forEach(s => (queryString[s[0]] = s[1])); return queryString; }; From 46d5ffc05b5dde9b85914f700fe012821f21c968 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sat, 11 Jan 2020 10:47:57 +0530 Subject: [PATCH 3/4] fix: typo --- assets/js/oauth.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/js/oauth.js b/assets/js/oauth.js index 9c57bfd34..0f2c866ed 100644 --- a/assets/js/oauth.js +++ b/assets/js/oauth.js @@ -70,7 +70,7 @@ const sha256 = plain => { }; // Base64-urlencodes the input string const base64urlencode = ( - str // Convert the ArrayBuffer to string using Uint8 array to conver to what btoa accepts. + str // Convert the ArrayBuffer to string using Uint8 array to convert to what btoa accepts. ) => // btoa accepts chars only within ascii 0-255 and base64 encodes them. // Then convert the base64 encoded to base64url encoded From caf33ba87e88d253fd5e65f290ae7e1db2f95c11 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sat, 11 Jan 2020 10:48:12 +0530 Subject: [PATCH 4/4] refactor: use const --- assets/js/oauth.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/js/oauth.js b/assets/js/oauth.js index 0f2c866ed..022c33627 100644 --- a/assets/js/oauth.js +++ b/assets/js/oauth.js @@ -81,7 +81,7 @@ const base64urlencode = ( .replace(/=+$/, ""); // Return the base64-urlencoded sha256 hash for the PKCE challenge const pkceChallengeFromVerifier = async v => { - let hashed = await sha256(v); + const hashed = await sha256(v); return base64urlencode(hashed); };