btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Explicitly pass radix 10 to parseInt functions in toBeLevelxxx() to avoid unexpected results

Browse Source
This commit is contained in:
Karel De Smet
2020-12-22 19:19:21 +01:00
parent a61e6efdd4
commit ea227e09fa
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
helpers/postwomanTesting.js
View File

@@ -109,7 +109,7 @@ class Expectation {
) )
} }
toBeLevel2xx() { toBeLevel2xx() {
const code = parseInt(this.expectValue) const code = parseInt(this.expectValue, 10)
if (Number.isNaN(code)) { if (Number.isNaN(code)) {
return this._fail(`Expected 200-level status but could not parse value ${this.expectValue}`) return this._fail(`Expected 200-level status but could not parse value ${this.expectValue}`)
} }
@@ -118,7 +118,7 @@ class Expectation {
: this._fail(this._fmtNot(`Expected ${this.expectValue} to (not)be 200-level status`)) : this._fail(this._fmtNot(`Expected ${this.expectValue} to (not)be 200-level status`))
} }
toBeLevel3xx() { toBeLevel3xx() {
const code = parseInt(this.expectValue) const code = parseInt(this.expectValue, 10)
if (Number.isNaN(code)) { if (Number.isNaN(code)) {
return this._fail(`Expected 300-level status but could not parse value ${this.expectValue}`) return this._fail(`Expected 300-level status but could not parse value ${this.expectValue}`)
} }
@@ -127,7 +127,7 @@ class Expectation {
: this._fail(this._fmtNot(`Expected ${this.expectValue} to (not)be 300-level status`)) : this._fail(this._fmtNot(`Expected ${this.expectValue} to (not)be 300-level status`))
} }
toBeLevel4xx() { toBeLevel4xx() {
const code = parseInt(this.expectValue) const code = parseInt(this.expectValue, 10)
if (Number.isNaN(code)) { if (Number.isNaN(code)) {
return this._fail(`Expected 400-level status but could not parse value ${this.expectValue}`) return this._fail(`Expected 400-level status but could not parse value ${this.expectValue}`)
} }
@@ -136,7 +136,7 @@ class Expectation {
: this._fail(this._fmtNot(`Expected ${this.expectValue} to (not)be 400-level status`)) : this._fail(this._fmtNot(`Expected ${this.expectValue} to (not)be 400-level status`))
} }
toBeLevel5xx() { toBeLevel5xx() {
const code = parseInt(this.expectValue) const code = parseInt(this.expectValue, 10)
if (Number.isNaN(code)) { if (Number.isNaN(code)) {
return this._fail(`Expected 500-level status but could not parse value ${this.expectValue}`) return this._fail(`Expected 500-level status but could not parse value ${this.expectValue}`)
} }