btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

feat: Ability to toggle cookies to work in HTTP (#4194)

Browse Source 
* feat: added new env variable

* feat: made http secure cookie conditional

* chore: added comments to env files

* chore: changed target of hopp-old-backend service to prod
This commit is contained in:
Balu Babu
2024-07-24 21:44:39 +05:30
committed by GitHub
parent 2917d50c6a
commit df730e4d21
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.env.example
View File

@@ -9,6 +9,9 @@ MAGIC_LINK_TOKEN_VALIDITY= 3
REFRESH_TOKEN_VALIDITY="604800000" # Default validity is 7 days (604800000 ms) in ms REFRESH_TOKEN_VALIDITY="604800000" # Default validity is 7 days (604800000 ms) in ms
ACCESS_TOKEN_VALIDITY="86400000" # Default validity is 1 day (86400000 ms) in ms ACCESS_TOKEN_VALIDITY="86400000" # Default validity is 1 day (86400000 ms) in ms
SESSION_SECRET='add some secret here' SESSION_SECRET='add some secret here'
# Reccomended to be true, set to false if you are using http
# Note: Some auth providers may not support http requests
ALLOW_SECURE_COOKIES=true
# Hoppscotch App Domain Config # Hoppscotch App Domain Config
REDIRECT_URL="http://localhost:3000" REDIRECT_URL="http://localhost:3000"

4
packages/hoppscotch-backend/src/auth/helper.ts
View File

@@ -52,13 +52,13 @@ export const authCookieHandler = (
res.cookie(AuthTokenType.ACCESS_TOKEN, authTokens.access_token, { res.cookie(AuthTokenType.ACCESS_TOKEN, authTokens.access_token, {
httpOnly: true, httpOnly: true,
secure: true, secure: configService.get('ALLOW_SECURE_COOKIES') === 'true',
sameSite: 'lax', sameSite: 'lax',
maxAge: accessTokenValidity, maxAge: accessTokenValidity,
}); });
res.cookie(AuthTokenType.REFRESH_TOKEN, authTokens.refresh_token, { res.cookie(AuthTokenType.REFRESH_TOKEN, authTokens.refresh_token, {
httpOnly: true, httpOnly: true,
secure: true, secure: configService.get('ALLOW_SECURE_COOKIES') === 'true',
sameSite: 'lax', sameSite: 'lax',
maxAge: refreshTokenValidity, maxAge: refreshTokenValidity,
}); });