refactor: improvements made to how banners are to be dismissed (#3656)

2023-12-15 17:08:57 +05:30
parent 93082c3816
commit cf8b5975ac
4 changed files with 6 additions and 2 deletions
--- a/packages/hoppscotch-common/src/components/app/Header.vue
+++ b/packages/hoppscotch-common/src/components/app/Header.vue
@@ -214,7 +214,7 @@
    <AppBanner
      v-if="bannerContent"
      :banner="bannerContent"
-      :dismissible="true"
+      :dismissable="bannerContent.dismissible"
      @dismiss="dismissOfflineBanner"
    />
    <TeamsModal :show="showTeamsModal" @hide-modal="showTeamsModal = false" />
@@ -295,6 +295,7 @@ const offlineBanner: BannerContent = {
  text: (t) => t("helpers.offline"),
  alternateText: (t) => t("helpers.offline_short"),
  score: BANNER_PRIORITY_HIGH,
+  dismissible: true,
 }

 const network = reactive(useNetwork())