From cb4b8a587692d90955c53fd6f1b7887c67ca375d Mon Sep 17 00:00:00 2001
From: Mir Arif Hasan <arif.ishan05@gmail.com>
Date: Tue, 19 Dec 2023 17:10:36 +0600
Subject: [PATCH] fix: feedback

---
 .../src/infra-config/infra-config.service.ts  | 43 +++++++------------
 1 file changed, 15 insertions(+), 28 deletions(-)

diff --git a/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts b/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts
index bc765ae08..c1d419224 100644
--- a/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts
+++ b/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts
@@ -192,41 +192,28 @@ export class InfraConfigService implements OnModuleInit {
   isServiceConfigured(service: AuthProvider) {
     switch (service) {
       case AuthProvider.GOOGLE:
-        if (
-          !this.configService.get<string>('INFRA.GOOGLE_CLIENT_ID') ||
-          !this.configService.get<string>('INFRA.GOOGLE_CLIENT_SECRET')
-        ) {
-          return false;
-        }
-        break;
+        return (
+          this.configService.get<string>('INFRA.GOOGLE_CLIENT_ID') &&
+          this.configService.get<string>('INFRA.GOOGLE_CLIENT_SECRET')
+        );
       case AuthProvider.GITHUB:
-        if (
-          !this.configService.get<string>('INFRA.GITHUB_CLIENT_ID') ||
+        return (
+          this.configService.get<string>('INFRA.GITHUB_CLIENT_ID') &&
           !this.configService.get<string>('INFRA.GITHUB_CLIENT_SECRET')
-        ) {
-          return false;
-        }
-        break;
+        );
       case AuthProvider.MICROSOFT:
-        if (
-          !this.configService.get<string>('INFRA.MICROSOFT_CLIENT_ID') ||
+        return (
+          this.configService.get<string>('INFRA.MICROSOFT_CLIENT_ID') &&
           !this.configService.get<string>('INFRA.MICROSOFT_CLIENT_SECRET')
-        ) {
-          return false;
-        }
-        break;
+        );
       case AuthProvider.EMAIL:
-        if (
-          !this.configService.get<string>('INFRA.MAILER_SMTP_URL') ||
-          !this.configService.get<string>('INFRA.MAILER_ADDRESS_FROM')
-        ) {
-          return false;
-        }
-        break;
+        return (
+          this.configService.get<string>('INFRA.MAILER_SMTP_URL') &&
+          this.configService.get<string>('INFRA.MAILER_ADDRESS_FROM')
+        );
       default:
-        break;
+        return false;
     }
-    return true;
   }
 
   /**