diff --git a/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts b/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts index bc765ae08..c1d419224 100644 --- a/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts +++ b/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts @@ -192,41 +192,28 @@ export class InfraConfigService implements OnModuleInit { isServiceConfigured(service: AuthProvider) { switch (service) { case AuthProvider.GOOGLE: - if ( - !this.configService.get('INFRA.GOOGLE_CLIENT_ID') || - !this.configService.get('INFRA.GOOGLE_CLIENT_SECRET') - ) { - return false; - } - break; + return ( + this.configService.get('INFRA.GOOGLE_CLIENT_ID') && + this.configService.get('INFRA.GOOGLE_CLIENT_SECRET') + ); case AuthProvider.GITHUB: - if ( - !this.configService.get('INFRA.GITHUB_CLIENT_ID') || + return ( + this.configService.get('INFRA.GITHUB_CLIENT_ID') && !this.configService.get('INFRA.GITHUB_CLIENT_SECRET') - ) { - return false; - } - break; + ); case AuthProvider.MICROSOFT: - if ( - !this.configService.get('INFRA.MICROSOFT_CLIENT_ID') || + return ( + this.configService.get('INFRA.MICROSOFT_CLIENT_ID') && !this.configService.get('INFRA.MICROSOFT_CLIENT_SECRET') - ) { - return false; - } - break; + ); case AuthProvider.EMAIL: - if ( - !this.configService.get('INFRA.MAILER_SMTP_URL') || - !this.configService.get('INFRA.MAILER_ADDRESS_FROM') - ) { - return false; - } - break; + return ( + this.configService.get('INFRA.MAILER_SMTP_URL') && + this.configService.get('INFRA.MAILER_ADDRESS_FROM') + ); default: - break; + return false; } - return true; } /**