From c98de5988e3265df7129c0153ef43b7f6565c418 Mon Sep 17 00:00:00 2001 From: liyasthomas Date: Thu, 20 May 2021 14:24:14 +0530 Subject: [PATCH] fix: clean input value in modals - fixed #1662 --- components/collections/Add.vue | 5 +++-- components/collections/AddFolder.vue | 4 +++- components/collections/Edit.vue | 5 +++-- components/collections/EditFolder.vue | 4 +++- components/collections/EditRequest.vue | 4 +++- components/collections/graphql/Add.vue | 6 +++--- components/collections/graphql/AddFolder.vue | 19 ++++++++++++++++++- components/collections/graphql/Edit.vue | 5 +++-- components/collections/graphql/EditFolder.vue | 5 +++-- .../collections/graphql/EditRequest.vue | 6 +++--- components/environments/Add.vue | 6 +++--- components/environments/Edit.vue | 6 +++--- components/teams/Add.vue | 5 +++-- components/teams/Edit.vue | 2 +- 14 files changed, 55 insertions(+), 27 deletions(-) diff --git a/components/collections/Add.vue b/components/collections/Add.vue index bee565abe..8e8dc3535 100644 --- a/components/collections/Add.vue +++ b/components/collections/Add.vue @@ -43,16 +43,17 @@ export default { }, data() { return { - name: undefined, + name: null, } }, methods: { addNewCollection() { this.$emit("submit", this.name) + this.hideModal() }, hideModal() { + this.name = null this.$emit("hide-modal") - this.$data.name = undefined }, }, } diff --git a/components/collections/AddFolder.vue b/components/collections/AddFolder.vue index 12905a8ca..0069261f2 100644 --- a/components/collections/AddFolder.vue +++ b/components/collections/AddFolder.vue @@ -46,7 +46,7 @@ export default { }, data() { return { - name: undefined, + name: null, } }, methods: { @@ -56,8 +56,10 @@ export default { folder: this.folder, path: this.folderPath || `${this.collectionIndex}`, }) + this.hideModal() }, hideModal() { + this.name = null this.$emit("hide-modal") }, }, diff --git a/components/collections/Edit.vue b/components/collections/Edit.vue index c1b8cf9ca..6c8dd5886 100644 --- a/components/collections/Edit.vue +++ b/components/collections/Edit.vue @@ -44,16 +44,17 @@ export default { }, data() { return { - name: undefined, + name: null, } }, methods: { saveCollection() { this.$emit("submit", this.name) + this.hideModal() }, hideModal() { + this.name = null this.$emit("hide-modal") - this.$data.name = undefined }, }, } diff --git a/components/collections/EditFolder.vue b/components/collections/EditFolder.vue index ca345464b..f300a928f 100644 --- a/components/collections/EditFolder.vue +++ b/components/collections/EditFolder.vue @@ -42,14 +42,16 @@ export default { }, data() { return { - name: undefined, + name: null, } }, methods: { editFolder() { this.$emit("submit", this.name) + this.hideModal() }, hideModal() { + this.name = null this.$emit("hide-modal") }, }, diff --git a/components/collections/EditRequest.vue b/components/collections/EditRequest.vue index 7d92c5763..d2f1bb655 100644 --- a/components/collections/EditRequest.vue +++ b/components/collections/EditRequest.vue @@ -45,15 +45,17 @@ export default { data() { return { requestUpdateData: { - name: undefined, + name: null, }, } }, methods: { saveRequest() { this.$emit("submit", this.requestUpdateData) + this.hideModal() }, hideModal() { + this.requestUpdateData = { name: null } this.$emit("hide-modal") }, }, diff --git a/components/collections/graphql/Add.vue b/components/collections/graphql/Add.vue index 1c908f32b..c94e34de0 100644 --- a/components/collections/graphql/Add.vue +++ b/components/collections/graphql/Add.vue @@ -45,7 +45,7 @@ export default { }, data() { return { - name: undefined, + name: null, } }, methods: { @@ -70,12 +70,12 @@ export default { name: this.$data.name, flag: "graphql", }) - this.$emit("hide-modal") this.syncCollections() + this.hideModal() }, hideModal() { + this.name = null this.$emit("hide-modal") - this.$data.name = undefined }, }, } diff --git a/components/collections/graphql/AddFolder.vue b/components/collections/graphql/AddFolder.vue index 12905a8ca..d46f93a40 100644 --- a/components/collections/graphql/AddFolder.vue +++ b/components/collections/graphql/AddFolder.vue @@ -37,6 +37,8 @@