From c90aaec65d43bcad7d37d00e0699714b76d84df0 Mon Sep 17 00:00:00 2001 From: Akash K <57758277+amk-dev@users.noreply.github.com> Date: Tue, 1 Oct 2024 16:17:31 +0530 Subject: [PATCH] fix: update copy + improve ux on ai experiments (#4393) Co-authored-by: jamesgeorge007 <25279263+jamesgeorge007@users.noreply.github.com> --- packages/hoppscotch-common/locales/en.json | 4 ++- .../aiexperiments/ModifyBodyModal.vue | 27 ++++++++++++++++--- .../src/components/collections/AddRequest.vue | 7 ++++- .../components/collections/EditRequest.vue | 7 ++++- .../components/collections/SaveRequest.vue | 7 ++++- .../collections/graphql/AddRequest.vue | 7 ++++- .../collections/graphql/EditRequest.vue | 7 ++++- .../src/composables/ai-experiments.ts | 6 ++--- 8 files changed, 59 insertions(+), 13 deletions(-) diff --git a/packages/hoppscotch-common/locales/en.json b/packages/hoppscotch-common/locales/en.json index 875ff64d5..fef7e0347 100644 --- a/packages/hoppscotch-common/locales/en.json +++ b/packages/hoppscotch-common/locales/en.json @@ -1140,12 +1140,14 @@ "generate_request_name": "Generate Request Name Using AI", "generate_or_modify_request_body": "Generate or Modify Request Body", "modify_with_ai": "Modify with AI", + "generate": "Generate", "generate_or_modify_request_body_input_placeholder": "Enter your prompt to modify request body", "accept_change": "Accept Change", "feedback_success": "Feedback submitted successfully", "feedback_failure": "Failed to submit feedback", "feedback_thank_you": "Thank you for your feedback!", "feedback_cta_text_long": "Rate the generation, helps us to improve", - "feedback_cta_request_name": "Did you like name generated?" + "feedback_cta_request_name": "Did you like the generated name?", + "modify_request_body_error": "Failed to modify request body" } } diff --git a/packages/hoppscotch-common/src/components/aiexperiments/ModifyBodyModal.vue b/packages/hoppscotch-common/src/components/aiexperiments/ModifyBodyModal.vue index 66957de27..910ba57d9 100644 --- a/packages/hoppscotch-common/src/components/aiexperiments/ModifyBodyModal.vue +++ b/packages/hoppscotch-common/src/components/aiexperiments/ModifyBodyModal.vue @@ -48,16 +48,30 @@ const { submitFeedback, isSubmitFeedbackPending } = useSubmitFeedback() 'ai_experiments.generate_or_modify_request_body_input_placeholder' )}`" class="flex flex-1 bg-transparent px-6 text-base text-secondaryDark" + @keypress=" + async (e) => { + if (e.key === 'Enter') { + await modifyRequestBody() + submittedFeedback = false + } + } + " /> @@ -100,7 +114,14 @@ const { submitFeedback, isSubmitFeedbackPending } = useSubmitFeedback() diff --git a/packages/hoppscotch-common/src/components/collections/AddRequest.vue b/packages/hoppscotch-common/src/components/collections/AddRequest.vue index 011c67dfb..1f8df8824 100644 --- a/packages/hoppscotch-common/src/components/collections/AddRequest.vue +++ b/packages/hoppscotch-common/src/components/collections/AddRequest.vue @@ -25,7 +25,12 @@ 'animate-pulse': isGenerateRequestNamePending, }" :title="t('ai_experiments.generate_request_name')" - @click="generateRequestName(props.requestContext)" + @click=" + async () => { + await generateRequestName(props.requestContext) + submittedFeedback = false + } + " /> diff --git a/packages/hoppscotch-common/src/components/collections/EditRequest.vue b/packages/hoppscotch-common/src/components/collections/EditRequest.vue index be3901e6d..6f9a7c48a 100644 --- a/packages/hoppscotch-common/src/components/collections/EditRequest.vue +++ b/packages/hoppscotch-common/src/components/collections/EditRequest.vue @@ -25,7 +25,12 @@ 'animate-pulse': isGenerateRequestNamePending, }" :title="t('ai_experiments.generate_request_name')" - @click="generateRequestName(props.requestContext)" + @click=" + async () => { + await generateRequestName(props.requestContext) + submittedFeedback = false + } + " /> diff --git a/packages/hoppscotch-common/src/components/collections/SaveRequest.vue b/packages/hoppscotch-common/src/components/collections/SaveRequest.vue index 7531b10ee..21b67ae4f 100644 --- a/packages/hoppscotch-common/src/components/collections/SaveRequest.vue +++ b/packages/hoppscotch-common/src/components/collections/SaveRequest.vue @@ -28,7 +28,12 @@ 'animate-pulse': isGenerateRequestNamePending, }" :title="t('ai_experiments.generate_request_name')" - @click="generateRequestName(requestContext)" + @click=" + async () => { + await generateRequestName(requestContext) + submittedFeedback = false + } + " /> diff --git a/packages/hoppscotch-common/src/components/collections/graphql/AddRequest.vue b/packages/hoppscotch-common/src/components/collections/graphql/AddRequest.vue index 757c76022..dc5e52e78 100644 --- a/packages/hoppscotch-common/src/components/collections/graphql/AddRequest.vue +++ b/packages/hoppscotch-common/src/components/collections/graphql/AddRequest.vue @@ -25,7 +25,12 @@ 'animate-pulse': isGenerateRequestNamePending, }" :title="t('ai_experiments.generate_request_name')" - @click="generateRequestName(props.requestContext)" + @click=" + async () => { + await generateRequestName(props.requestContext) + submittedFeedback = false + } + " /> diff --git a/packages/hoppscotch-common/src/components/collections/graphql/EditRequest.vue b/packages/hoppscotch-common/src/components/collections/graphql/EditRequest.vue index 142beca47..01a07ea41 100644 --- a/packages/hoppscotch-common/src/components/collections/graphql/EditRequest.vue +++ b/packages/hoppscotch-common/src/components/collections/graphql/EditRequest.vue @@ -25,7 +25,12 @@ 'animate-pulse': isGenerateRequestNamePending, }" :title="t('ai_experiments.generate_request_name')" - @click="generateRequestName" + @click=" + async () => { + await generateRequestName(props.requestContext) + submittedFeedback = false + } + " /> diff --git a/packages/hoppscotch-common/src/composables/ai-experiments.ts b/packages/hoppscotch-common/src/composables/ai-experiments.ts index 0bdac1f92..f14d1840a 100644 --- a/packages/hoppscotch-common/src/composables/ai-experiments.ts +++ b/packages/hoppscotch-common/src/composables/ai-experiments.ts @@ -122,7 +122,7 @@ export const useModifyRequestBody = ( isModifyRequestBodyPending.value = true if (!modifyRequestBodyForPlatform) { - toast.error(t("request.modify_request_body_error")) + toast.error(t("ai_experiments.modify_request_body_error")) isModifyRequestBodyPending.value = false return } @@ -133,7 +133,7 @@ export const useModifyRequestBody = ( ) if (result && E.isLeft(result)) { - toast.error(t("request.modify_request_body_error")) + toast.error(t("ai_experiments.modify_request_body_error")) isModifyRequestBodyPending.value = false return } @@ -186,8 +186,6 @@ export const useSubmitFeedback = () => { isSubmitFeedbackPending.value = false - toast.success(t("ai_experiments.feedback_success")) - return E.right(undefined) }