From be1bb520a0cdc6f44d10834f1f15b6c76f73254a Mon Sep 17 00:00:00 2001
From: liyasthomas <liyascthomas@gmail.com>
Date: Tue, 22 Feb 2022 12:29:17 +0530
Subject: [PATCH] feat: add new variables to globals or create new environment

---
 .../components/environments/Add.vue           | 13 +++-
 .../components/http/TestResult.vue            | 60 ++++++++++++++++++-
 .../hoppscotch-app/helpers/testSnippets.js    |  5 ++
 3 files changed, 74 insertions(+), 4 deletions(-)

diff --git a/packages/hoppscotch-app/components/environments/Add.vue b/packages/hoppscotch-app/components/environments/Add.vue
index 2188289e7..f8da6289e 100644
--- a/packages/hoppscotch-app/components/environments/Add.vue
+++ b/packages/hoppscotch-app/components/environments/Add.vue
@@ -38,12 +38,18 @@
 
 <script lang="ts">
 import { defineComponent } from "@nuxtjs/composition-api"
-import { createEnvironment } from "~/newstore/environments"
+import { useReadonlyStream } from "~/helpers/utils/composables"
+import { createEnvironment, environments$ } from "~/newstore/environments"
 
 export default defineComponent({
   props: {
     show: Boolean,
   },
+  setup() {
+    return {
+      envList: useReadonlyStream(environments$, []),
+    }
+  },
   data() {
     return {
       name: null as string | null,
@@ -56,6 +62,11 @@ export default defineComponent({
         return
       }
       createEnvironment(this.name)
+      // TODO: find better way to get index of new environment
+      this.$emit("environment-added", {
+        name: this.name,
+        index: this.envList.length - 1,
+      })
       this.hideModal()
     },
     hideModal() {
diff --git a/packages/hoppscotch-app/components/http/TestResult.vue b/packages/hoppscotch-app/components/http/TestResult.vue
index 10519b565..52c6c567c 100644
--- a/packages/hoppscotch-app/components/http/TestResult.vue
+++ b/packages/hoppscotch-app/components/http/TestResult.vue
@@ -35,7 +35,7 @@
             </summary>
             <div class="divide-y divide-dividerLight">
               <div
-                v-if="noEnvSelected"
+                v-if="noEnvSelected && !globalHasAdditions"
                 class="flex bg-error p-4 text-secondaryDark"
               >
                 <i class="mr-4 material-icons"> warning </i>
@@ -48,11 +48,13 @@
                       :label="t('environment.add_to_global')"
                       class="text-tiny !bg-primary"
                       filled
+                      @click.native="addEnvToGlobal()"
                     />
                     <ButtonSecondary
                       :label="t('environment.create_new')"
                       class="text-tiny !bg-primary"
                       filled
+                      @click.native="displayModalAdd(true)"
                     />
                   </p>
                 </div>
@@ -165,25 +167,44 @@
         class="my-4"
       />
     </div>
+    <EnvironmentsAdd
+      :show="showModalAdd"
+      @hide-modal="displayModalAdd(false)"
+      @environment-added="createNewEnv($event)"
+    />
   </div>
 </template>
 
 <script setup lang="ts">
-import { computed } from "@nuxtjs/composition-api"
+import { computed, Ref, ref } from "@nuxtjs/composition-api"
+import isEqual from "lodash/isEqual"
 import {
   useReadonlyStream,
   useI18n,
   useStream,
 } from "~/helpers/utils/composables"
 import {
+  globalEnv$,
   selectedEnvIndex$,
   setCurrentEnvironment,
+  setGlobalEnvVariables,
+  updateEnvironment,
 } from "~/newstore/environments"
 import { restTestResults$, setRESTTestResults } from "~/newstore/RESTSession"
+import { HoppTestResult } from "~/helpers/types/HoppTestResult"
 
 const t = useI18n()
 
-const testResults = useReadonlyStream(restTestResults$, null)
+const showModalAdd = ref(false)
+
+const displayModalAdd = (shouldDisplay: boolean) => {
+  showModalAdd.value = shouldDisplay
+}
+
+const testResults = useReadonlyStream(
+  restTestResults$,
+  null
+) as Ref<HoppTestResult | null>
 
 const clearContent = () => setRESTTestResults(null)
 
@@ -205,5 +226,38 @@ const selectedEnvironmentIndex = useStream(
   setCurrentEnvironment
 )
 
+const globalEnvVars = useReadonlyStream(globalEnv$, []) as Ref<
+  Array<{
+    key: string
+    value: string
+  }>
+>
+
 const noEnvSelected = computed(() => selectedEnvironmentIndex.value === -1)
+
+const globalHasAdditions = computed(() => {
+  if (!testResults.value?.envDiff.selected.additions) return false
+  return (
+    testResults.value.envDiff.selected.additions.every(
+      (x) => globalEnvVars.value.findIndex((y) => isEqual(x, y)) !== -1
+    ) ?? false
+  )
+})
+
+const addEnvToGlobal = () => {
+  if (!testResults.value?.envDiff.selected.additions) return
+  setGlobalEnvVariables([
+    ...globalEnvVars.value,
+    ...testResults.value.envDiff.selected.additions,
+  ])
+}
+
+const createNewEnv = ({ name, index }: { name: string; index: number }) => {
+  if (!testResults.value?.envDiff.selected.additions) return
+  updateEnvironment(index, {
+    name,
+    variables: testResults.value.envDiff.selected.additions,
+  })
+  setCurrentEnvironment(index)
+}
 </script>
diff --git a/packages/hoppscotch-app/helpers/testSnippets.js b/packages/hoppscotch-app/helpers/testSnippets.js
index 594caef19..002d39578 100644
--- a/packages/hoppscotch-app/helpers/testSnippets.js
+++ b/packages/hoppscotch-app/helpers/testSnippets.js
@@ -1,4 +1,9 @@
 export default [
+  {
+    name: "Environment: Set an environment variable",
+    script: `\n\n// Set an environment variable
+pw.env.set("variable", "value");`,
+  },
   {
     name: "Response: Status code is 200",
     script: `\n\n// Check status code is 200