From b5cf2fa1b4d3ca1c8cf4809dbc29b58dbad03cce Mon Sep 17 00:00:00 2001
From: Joel Jacob Stephen <70131076+JoelJacobStephen@users.noreply.github.com>
Date: Tue, 5 Mar 2024 09:37:01 +0530
Subject: [PATCH] refactor: improved toggleDataSharing function no matter the
 toggle value

---
 .../src/components/setup/DataSharingAndNewsletter.vue         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue b/packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
index 3ff9284b6..7a244db93 100644
--- a/packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
+++ b/packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
@@ -94,6 +94,7 @@ const dataSharingMutation = useMutation(ToggleAnalyticsCollectionDocument);
 
 const toggleDataSharing = async () => {
   const status = dataSharingToggle.value ? 'ENABLE' : 'DISABLE';
+
   const variables = { status };
   const result = await dataSharingMutation.executeMutation(
     variables as ToggleAnalyticsCollectionMutationVariables
@@ -125,8 +126,7 @@ const toggleNewsletter = async () => {
 
 // Submit selections made
 const submitSelection = async () => {
-  const dataSharingResult =
-    dataSharingToggle.value && (await toggleDataSharing());
+  const dataSharingResult = await toggleDataSharing();
   const newsletterResult = newsletterToggle.value && (await toggleNewsletter());
 
   const setupDataComplete = !dataSharingToggle.value || dataSharingResult;