feat: added all feedback

This commit is contained in:
Mir Arif Hasan
2023-07-11 16:58:17 +06:00
committed by Andrew Bastin
parent 54bef30cf8
commit b58acfe8dc
4 changed files with 54 additions and 21 deletions

View File

@@ -11,6 +11,13 @@ import {
import { throwErr } from 'src/utils';
import { TeamService } from 'src/team/team.service';
/**
* This guard only allows user to execute the resolver
* 1. If user is invitee, allow
* 2. Or else, if user is team member, allow
*
* TLDR: Allow if user is invitee or team member
*/
@Injectable()
export class TeamInviteViewerGuard implements CanActivate {
constructor(
@@ -33,8 +40,7 @@ export class TeamInviteViewerGuard implements CanActivate {
const invitation = await this.teamInviteService.getInvitation(inviteID);
if (O.isNone(invitation)) throwErr(TEAM_INVITE_NO_INVITE_FOUND);
// Check if the user and the invite email match, else if we can resolver the user as a team member
// any better solution ?
// Check if the user and the invite email match, else if user is a team member
if (
user.email?.toLowerCase() !== invitation.value.inviteeEmail.toLowerCase()
) {