From afa750e409e45c1e27fb223c1bbdb851715bb710 Mon Sep 17 00:00:00 2001 From: liyasthomas Date: Tue, 23 Nov 2021 20:01:45 +0530 Subject: [PATCH] fix: validate empty endpoints before sending request - resolved #1968 --- packages/hoppscotch-app/components/http/Request.vue | 9 ++++++--- packages/hoppscotch-app/locales/af.json | 1 + packages/hoppscotch-app/locales/ar.json | 1 + packages/hoppscotch-app/locales/ca.json | 1 + packages/hoppscotch-app/locales/cn.json | 1 + packages/hoppscotch-app/locales/cs.json | 1 + packages/hoppscotch-app/locales/da.json | 1 + packages/hoppscotch-app/locales/de.json | 1 + packages/hoppscotch-app/locales/el.json | 1 + packages/hoppscotch-app/locales/en.json | 1 + packages/hoppscotch-app/locales/es.json | 1 + packages/hoppscotch-app/locales/fi.json | 1 + packages/hoppscotch-app/locales/fr.json | 1 + packages/hoppscotch-app/locales/he.json | 1 + packages/hoppscotch-app/locales/hu.json | 1 + packages/hoppscotch-app/locales/it.json | 1 + packages/hoppscotch-app/locales/ja.json | 1 + packages/hoppscotch-app/locales/ko.json | 1 + packages/hoppscotch-app/locales/nl.json | 1 + packages/hoppscotch-app/locales/no.json | 1 + packages/hoppscotch-app/locales/pl.json | 1 + packages/hoppscotch-app/locales/pt-br.json | 1 + packages/hoppscotch-app/locales/pt.json | 1 + packages/hoppscotch-app/locales/ro.json | 1 + packages/hoppscotch-app/locales/ru.json | 1 + packages/hoppscotch-app/locales/sr.json | 1 + packages/hoppscotch-app/locales/sv.json | 1 + packages/hoppscotch-app/locales/tr.json | 1 + packages/hoppscotch-app/locales/tw.json | 1 + packages/hoppscotch-app/locales/uk.json | 1 + packages/hoppscotch-app/locales/vi.json | 1 + 31 files changed, 36 insertions(+), 3 deletions(-) diff --git a/packages/hoppscotch-app/components/http/Request.vue b/packages/hoppscotch-app/components/http/Request.vue index 3e56d187f..08dee8d63 100644 --- a/packages/hoppscotch-app/components/http/Request.vue +++ b/packages/hoppscotch-app/components/http/Request.vue @@ -288,6 +288,11 @@ watch(loading, () => { }) const newSendRequest = async () => { + if (newEndpoint.value === "" || /^\s+$/.test(newEndpoint.value)) { + toast.error(`${t("empty.endpoint")}`) + return + } + loading.value = true // Double calling is because the function returns a TaskEither than should be executed @@ -387,9 +392,7 @@ const copyShareLink = (shareLink: string) => { } else { copyLinkIcon.value = "check" copyToClipboard(`https://hopp.sh/r${shareLink}`) - toast.success(`${t("state.copied_to_clipboard")}`, { - icon: "content_paste", - }) + toast.success(`${t("state.copied_to_clipboard")}`) setTimeout(() => (copyLinkIcon.value = "copy"), 2000) } } diff --git a/packages/hoppscotch-app/locales/af.json b/packages/hoppscotch-app/locales/af.json index 8bd400787..a1d5fdd58 100644 --- a/packages/hoppscotch-app/locales/af.json +++ b/packages/hoppscotch-app/locales/af.json @@ -138,6 +138,7 @@ "collection": "Versameling is leeg", "collections": "Versamelings is leeg", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Omgewings is leeg", "folder": "Vouer is leeg", "headers": "Hierdie versoek bevat geen opskrifte nie", diff --git a/packages/hoppscotch-app/locales/ar.json b/packages/hoppscotch-app/locales/ar.json index 07733c521..bee666f18 100644 --- a/packages/hoppscotch-app/locales/ar.json +++ b/packages/hoppscotch-app/locales/ar.json @@ -138,6 +138,7 @@ "collection": "المجموعة فارغة", "collections": "المجموعات فارغة", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "البيئات فارغة", "folder": "مجلد فارغ", "headers": "لا يحتوي هذا الطلب على أية رؤوس", diff --git a/packages/hoppscotch-app/locales/ca.json b/packages/hoppscotch-app/locales/ca.json index 399b1edf4..ced3e70f5 100644 --- a/packages/hoppscotch-app/locales/ca.json +++ b/packages/hoppscotch-app/locales/ca.json @@ -138,6 +138,7 @@ "collection": "La col·lecció està buida", "collections": "Les col·leccions estan buides", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Els entorns estan buits", "folder": "La carpeta està buida", "headers": "Aquesta sol·licitud no té cap capçalera", diff --git a/packages/hoppscotch-app/locales/cn.json b/packages/hoppscotch-app/locales/cn.json index 8cb858f6c..aa70b5025 100644 --- a/packages/hoppscotch-app/locales/cn.json +++ b/packages/hoppscotch-app/locales/cn.json @@ -138,6 +138,7 @@ "collection": "组合为空", "collections": "组合为空", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "环境为空", "folder": "文件夹为空", "headers": "该请求没有任何请求头", diff --git a/packages/hoppscotch-app/locales/cs.json b/packages/hoppscotch-app/locales/cs.json index 44a273bc9..8e8f49355 100644 --- a/packages/hoppscotch-app/locales/cs.json +++ b/packages/hoppscotch-app/locales/cs.json @@ -138,6 +138,7 @@ "collection": "Sbírka je prázdná", "collections": "Sbírky jsou prázdné", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Prostředí je prázdné", "folder": "Složka je prázdná", "headers": "Tento požadavek nemá žádná záhlaví", diff --git a/packages/hoppscotch-app/locales/da.json b/packages/hoppscotch-app/locales/da.json index ea55022e2..6f2db9f46 100644 --- a/packages/hoppscotch-app/locales/da.json +++ b/packages/hoppscotch-app/locales/da.json @@ -138,6 +138,7 @@ "collection": "Samlingen er tom", "collections": "Samlinger er tomme", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Miljøer er tomme", "folder": "Mappen er tom", "headers": "Denne anmodning har ingen overskrifter", diff --git a/packages/hoppscotch-app/locales/de.json b/packages/hoppscotch-app/locales/de.json index 9dc530d0f..8b27ec44c 100644 --- a/packages/hoppscotch-app/locales/de.json +++ b/packages/hoppscotch-app/locales/de.json @@ -138,6 +138,7 @@ "collection": "Sammlung ist leer", "collections": "Sammlungen sind leer", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Umgebungen sind leer", "folder": "Der Ordner ist leer", "headers": "Diese Anfrage hat keine Header", diff --git a/packages/hoppscotch-app/locales/el.json b/packages/hoppscotch-app/locales/el.json index 55771a2c7..6e8d61d93 100644 --- a/packages/hoppscotch-app/locales/el.json +++ b/packages/hoppscotch-app/locales/el.json @@ -138,6 +138,7 @@ "collection": "Η συλλογή είναι άδεια", "collections": "Οι συλλογές είναι άδειες", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Τα περιβάλλοντα είναι άδεια", "folder": "Ο φάκελος είναι άδειος", "headers": "Αυτό το αίτημα δεν έχει κεφαλίδες", diff --git a/packages/hoppscotch-app/locales/en.json b/packages/hoppscotch-app/locales/en.json index d498ac8d7..bb44bd205 100644 --- a/packages/hoppscotch-app/locales/en.json +++ b/packages/hoppscotch-app/locales/en.json @@ -138,6 +138,7 @@ "collection": "Collection is empty", "collections": "Collections are empty", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Environments are empty", "folder": "Folder is empty", "headers": "This request does not have any headers", diff --git a/packages/hoppscotch-app/locales/es.json b/packages/hoppscotch-app/locales/es.json index 58f2e3aec..7ab676d0d 100644 --- a/packages/hoppscotch-app/locales/es.json +++ b/packages/hoppscotch-app/locales/es.json @@ -138,6 +138,7 @@ "collection": "La colección está vacía", "collections": "Las colecciones están vacías", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Los entornos están vacíos", "folder": "La carpeta está vacía", "headers": "Esta petición no tiene encabezados", diff --git a/packages/hoppscotch-app/locales/fi.json b/packages/hoppscotch-app/locales/fi.json index 4a86bc087..2936a3495 100644 --- a/packages/hoppscotch-app/locales/fi.json +++ b/packages/hoppscotch-app/locales/fi.json @@ -138,6 +138,7 @@ "collection": "Kokoelma on tyhjä", "collections": "Kokoelmat ovat tyhjiä", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Ympäristöt ovat tyhjiä", "folder": "Kansio on tyhjä", "headers": "Tässä pyynnössä ei ole otsikoita", diff --git a/packages/hoppscotch-app/locales/fr.json b/packages/hoppscotch-app/locales/fr.json index 9086274aa..b155170bb 100644 --- a/packages/hoppscotch-app/locales/fr.json +++ b/packages/hoppscotch-app/locales/fr.json @@ -138,6 +138,7 @@ "collection": "La collection est vide", "collections": "Les collections sont vides", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Les environnements sont vides", "folder": "Le dossier est vide", "headers": "Cette requête n'a pas d'en-tête", diff --git a/packages/hoppscotch-app/locales/he.json b/packages/hoppscotch-app/locales/he.json index bce607f2a..daba2e798 100644 --- a/packages/hoppscotch-app/locales/he.json +++ b/packages/hoppscotch-app/locales/he.json @@ -138,6 +138,7 @@ "collection": "האוסף ריק", "collections": "האוספים ריקים", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "הסביבה ריקה", "folder": "התיקייה ריקה", "headers": "לבקשה זו אין כותרות", diff --git a/packages/hoppscotch-app/locales/hu.json b/packages/hoppscotch-app/locales/hu.json index c0486e038..5160b198b 100644 --- a/packages/hoppscotch-app/locales/hu.json +++ b/packages/hoppscotch-app/locales/hu.json @@ -138,6 +138,7 @@ "collection": "A gyűjtemény üres", "collections": "A gyűjtemények üresek", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "A környezet üres", "folder": "A mappa üres", "headers": "Ennek a kérésnek nincs fejléce", diff --git a/packages/hoppscotch-app/locales/it.json b/packages/hoppscotch-app/locales/it.json index a7733227f..6558dd793 100644 --- a/packages/hoppscotch-app/locales/it.json +++ b/packages/hoppscotch-app/locales/it.json @@ -138,6 +138,7 @@ "collection": "La raccolta è vuota", "collections": "Le raccolte sono vuote", "documentation": "Connetti ad un endpoint GraphQL per mostrare la documentazione", + "endpoint": "Endpoint cannot be empty", "environments": "Gli ambienti sono vuoti", "folder": "La cartella è vuota", "headers": "Questa richiesta non ha intestazioni", diff --git a/packages/hoppscotch-app/locales/ja.json b/packages/hoppscotch-app/locales/ja.json index 534e87944..913f67fa8 100644 --- a/packages/hoppscotch-app/locales/ja.json +++ b/packages/hoppscotch-app/locales/ja.json @@ -138,6 +138,7 @@ "collection": "コレクションは空です", "collections": "コレクションは空です", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "環境は空です", "folder": "フォルダが空です", "headers": "このリクエストにはヘッダーがありません", diff --git a/packages/hoppscotch-app/locales/ko.json b/packages/hoppscotch-app/locales/ko.json index dab2625bb..f9659c37f 100644 --- a/packages/hoppscotch-app/locales/ko.json +++ b/packages/hoppscotch-app/locales/ko.json @@ -138,6 +138,7 @@ "collection": "모음집이 비어 있습니다.", "collections": "모음집이 비어 있습니다.", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "환경이 비어 있습니다.", "folder": "폴더가 비어 있습니다.", "headers": "이 요청에는 헤더가 없습니다.", diff --git a/packages/hoppscotch-app/locales/nl.json b/packages/hoppscotch-app/locales/nl.json index f2936de41..18f5184e0 100644 --- a/packages/hoppscotch-app/locales/nl.json +++ b/packages/hoppscotch-app/locales/nl.json @@ -138,6 +138,7 @@ "collection": "Collectie is leeg", "collections": "Collecties zijn leeg", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Omgevingen zijn leeg", "folder": "Map is leeg", "headers": "Dit verzoek heeft geen headers", diff --git a/packages/hoppscotch-app/locales/no.json b/packages/hoppscotch-app/locales/no.json index 627caec7a..7b95f9527 100644 --- a/packages/hoppscotch-app/locales/no.json +++ b/packages/hoppscotch-app/locales/no.json @@ -138,6 +138,7 @@ "collection": "Samlingen er tom", "collections": "Samlingene er tomme", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Miljøer er tomme", "folder": "Mappen er tom", "headers": "Denne forespørselen har ingen overskrifter", diff --git a/packages/hoppscotch-app/locales/pl.json b/packages/hoppscotch-app/locales/pl.json index ea29f2228..b717764d8 100644 --- a/packages/hoppscotch-app/locales/pl.json +++ b/packages/hoppscotch-app/locales/pl.json @@ -138,6 +138,7 @@ "collection": "Kolekcja jest pusta", "collections": "Kolekcje są puste", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Środowiska są puste", "folder": "Folder jest pusty", "headers": "To żądanie nie ma żadnych nagłówków", diff --git a/packages/hoppscotch-app/locales/pt-br.json b/packages/hoppscotch-app/locales/pt-br.json index 1f2fb1308..f334d100f 100644 --- a/packages/hoppscotch-app/locales/pt-br.json +++ b/packages/hoppscotch-app/locales/pt-br.json @@ -138,6 +138,7 @@ "collection": "Coleção está vazia", "collections": "Coleções estão vazias", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Ambientes estão vazios", "folder": "Pasta está vazia", "headers": "Esta solicitação não possui cabeçalhos", diff --git a/packages/hoppscotch-app/locales/pt.json b/packages/hoppscotch-app/locales/pt.json index 1f2fb1308..f334d100f 100644 --- a/packages/hoppscotch-app/locales/pt.json +++ b/packages/hoppscotch-app/locales/pt.json @@ -138,6 +138,7 @@ "collection": "Coleção está vazia", "collections": "Coleções estão vazias", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Ambientes estão vazios", "folder": "Pasta está vazia", "headers": "Esta solicitação não possui cabeçalhos", diff --git a/packages/hoppscotch-app/locales/ro.json b/packages/hoppscotch-app/locales/ro.json index def78b2cb..ab50f052b 100644 --- a/packages/hoppscotch-app/locales/ro.json +++ b/packages/hoppscotch-app/locales/ro.json @@ -138,6 +138,7 @@ "collection": "Colecția este goală", "collections": "Colecțiile sunt goale", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Mediile sunt goale", "folder": "Dosarul este gol", "headers": "Această solicitare nu are anteturi", diff --git a/packages/hoppscotch-app/locales/ru.json b/packages/hoppscotch-app/locales/ru.json index 6d2d46b7f..9f9873184 100644 --- a/packages/hoppscotch-app/locales/ru.json +++ b/packages/hoppscotch-app/locales/ru.json @@ -138,6 +138,7 @@ "collection": "Коллекция пуста", "collections": "Коллекции пустые", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Окружения пусты", "folder": "Папка пуста", "headers": "У этого запроса нет заголовков", diff --git a/packages/hoppscotch-app/locales/sr.json b/packages/hoppscotch-app/locales/sr.json index 27c290f74..27647b743 100644 --- a/packages/hoppscotch-app/locales/sr.json +++ b/packages/hoppscotch-app/locales/sr.json @@ -138,6 +138,7 @@ "collection": "Збирка је празна", "collections": "Збирке су празне", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Окружења су празна", "folder": "Мапа је празна", "headers": "Овај захтев нема заглавља", diff --git a/packages/hoppscotch-app/locales/sv.json b/packages/hoppscotch-app/locales/sv.json index beb280809..3823d6288 100644 --- a/packages/hoppscotch-app/locales/sv.json +++ b/packages/hoppscotch-app/locales/sv.json @@ -138,6 +138,7 @@ "collection": "Samlingen är tom", "collections": "Samlingar är tomma", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Miljöer är tomma", "folder": "Mappen är tom", "headers": "Denna begäran har inga rubriker", diff --git a/packages/hoppscotch-app/locales/tr.json b/packages/hoppscotch-app/locales/tr.json index 595311cc5..78144841c 100644 --- a/packages/hoppscotch-app/locales/tr.json +++ b/packages/hoppscotch-app/locales/tr.json @@ -138,6 +138,7 @@ "collection": "Koleksiyon boş", "collections": "Koleksiyonlar boş", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Ortamlar boş", "folder": "Klasör boş", "headers": "Bu isteğin herhangi bir başlığı yok", diff --git a/packages/hoppscotch-app/locales/tw.json b/packages/hoppscotch-app/locales/tw.json index f1b662c00..a814ce2ba 100644 --- a/packages/hoppscotch-app/locales/tw.json +++ b/packages/hoppscotch-app/locales/tw.json @@ -138,6 +138,7 @@ "collection": "組合為空", "collections": "組合為空", "documentation": "連接至 GraphQL 端點以檢視文檔", + "endpoint": "Endpoint cannot be empty", "environments": "環境為空", "folder": "資料夾為空", "headers": "該請求沒有任何請求頭", diff --git a/packages/hoppscotch-app/locales/uk.json b/packages/hoppscotch-app/locales/uk.json index 5d640b77c..6865da507 100644 --- a/packages/hoppscotch-app/locales/uk.json +++ b/packages/hoppscotch-app/locales/uk.json @@ -138,6 +138,7 @@ "collection": "Колекція порожня", "collections": "Колекції порожні", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Середовища порожні", "folder": "Папка порожня", "headers": "Цей запит не має заголовків", diff --git a/packages/hoppscotch-app/locales/vi.json b/packages/hoppscotch-app/locales/vi.json index 95717a701..785bd5446 100644 --- a/packages/hoppscotch-app/locales/vi.json +++ b/packages/hoppscotch-app/locales/vi.json @@ -138,6 +138,7 @@ "collection": "Bộ sưu tập trống", "collections": "Bộ sưu tập trống", "documentation": "Connect to a GraphQL endpoint to view documentation", + "endpoint": "Endpoint cannot be empty", "environments": "Môi trường trống", "folder": "Tệp này rỗng", "headers": "Yêu cầu này không có bất kỳ tiêu đề nào",