From 9c21013a069956f4f9fbae6de1b67a8c4a46622d Mon Sep 17 00:00:00 2001
From: Rishabh Agarwal <45998880+RishabhAgarwal-2001@users.noreply.github.com>
Date: Tue, 1 Feb 2022 14:29:18 +0530
Subject: [PATCH] feat: handle test script execution failure (#2104)

Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
---
 .../components/http/TestResult.vue            | 19 +++++++++++++++++++
 .../hoppscotch-app/helpers/RequestRunner.ts   | 10 +++++++++-
 .../helpers/types/HoppTestResult.ts           |  1 +
 packages/hoppscotch-app/locales/en.json       |  6 ++++--
 4 files changed, 33 insertions(+), 3 deletions(-)

diff --git a/packages/hoppscotch-app/components/http/TestResult.vue b/packages/hoppscotch-app/components/http/TestResult.vue
index b2beeeb00..bab19666c 100644
--- a/packages/hoppscotch-app/components/http/TestResult.vue
+++ b/packages/hoppscotch-app/components/http/TestResult.vue
@@ -62,6 +62,25 @@
         </div>
       </div>
     </div>
+    <div
+      v-else-if="testResults && testResults.scriptError"
+      class="flex flex-col items-center justify-center flex-1 p-4"
+    >
+      <img
+        :src="`/images/states/${$colorMode.value}/youre_lost.svg`"
+        loading="lazy"
+        class="inline-flex flex-col object-contain object-center w-32 h-32 my-4"
+        :alt="`${t('error.test_script_fail')}`"
+      />
+      <span class="mb-2 font-semibold text-center">
+        {{ t("error.test_script_fail") }}
+      </span>
+      <span
+        class="max-w-sm mb-6 text-center whitespace-normal text-secondaryLight"
+      >
+        {{ t("helpers.test_script_fail") }}
+      </span>
+    </div>
     <div
       v-else
       class="flex flex-col items-center justify-center p-4 text-secondaryLight"
diff --git a/packages/hoppscotch-app/helpers/RequestRunner.ts b/packages/hoppscotch-app/helpers/RequestRunner.ts
index bd4b2dfa3..2453926a1 100644
--- a/packages/hoppscotch-app/helpers/RequestRunner.ts
+++ b/packages/hoppscotch-app/helpers/RequestRunner.ts
@@ -71,9 +71,15 @@ export const runRESTRequest$ = (): TaskEither<
               headers: res.headers,
             })()
 
-            // TODO: Handle script executation fails (isLeft)
             if (isRight(runResult)) {
               setRESTTestResults(translateToSandboxTestResults(runResult.right))
+            } else {
+              setRESTTestResults({
+                description: "",
+                expectResults: [],
+                tests: [],
+                scriptError: true,
+              })
             }
 
             subscription.unsubscribe()
@@ -95,7 +101,9 @@ function translateToSandboxTestResults(
     }
   }
   return {
+    description: "",
     expectResults: testDesc.expectResults,
     tests: testDesc.children.map(translateChildTests),
+    scriptError: false,
   }
 }
diff --git a/packages/hoppscotch-app/helpers/types/HoppTestResult.ts b/packages/hoppscotch-app/helpers/types/HoppTestResult.ts
index 7944b0bb8..31af5b58d 100644
--- a/packages/hoppscotch-app/helpers/types/HoppTestResult.ts
+++ b/packages/hoppscotch-app/helpers/types/HoppTestResult.ts
@@ -13,4 +13,5 @@ export type HoppTestResult = {
   tests: HoppTestData[]
   expectResults: HoppTestExpectResult[]
   description: string
+  scriptError: boolean
 }
diff --git a/packages/hoppscotch-app/locales/en.json b/packages/hoppscotch-app/locales/en.json
index 045d15544..03e76a4ee 100644
--- a/packages/hoppscotch-app/locales/en.json
+++ b/packages/hoppscotch-app/locales/en.json
@@ -182,7 +182,8 @@
     "network_fail": "Could not send request",
     "no_duration": "No duration",
     "script_fail": "Could not execute pre-request script",
-    "something_went_wrong": "Something went wrong"
+    "something_went_wrong": "Something went wrong",
+    "test_script_fail": "Could not execute post-request script"
   },
   "export": {
     "as_json": "Export as JSON",
@@ -217,7 +218,8 @@
     "post_request_tests": "Test scripts are written in JavaScript, and are run after the response is received.",
     "pre_request_script": "Pre-request scripts are written in JavaScript, and are run before the request is sent.",
     "script_fail": "It seems there is a glitch in the pre-request script. Check the error below and fix the script accordingly.",
-    "tests": "Write a test script to automate debugging."
+    "tests": "Write a test script to automate debugging.",
+    "test_script_fail": "There seems to be an error with test script. Please fix the errors and run tests again"
   },
   "hide": {
     "more": "Hide more",