btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

chore: serialize when logging errors (#2775)

Browse Source
This commit is contained in:
Akash K
2022-10-12 02:19:27 +05:30
committed by GitHub
parent 4d19b9249b
commit 971238cedb
2 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/hoppscotch-app/src/helpers/teams/TeamCollectionAdapter.ts
View File

@@ -470,7 +470,9 @@ export default class NewTeamCollectionAdapter {
this.teamCollectionAdded$ = teamCollAdded$.subscribe((result) => { this.teamCollectionAdded$ = teamCollAdded$.subscribe((result) => {
if (E.isLeft(result)) if (E.isLeft(result))
throw new Error(`Team Collection Added Error: ${result.left}`) throw new Error(
`Team Collection Added Error: ${JSON.stringify(result.left)}`
)
this.addCollection( this.addCollection(
{ {
@@ -493,7 +495,9 @@ export default class NewTeamCollectionAdapter {
this.teamCollectionUpdatedSub = teamCollUpdatedSub this.teamCollectionUpdatedSub = teamCollUpdatedSub
this.teamCollectionUpdated$ = teamCollUpdated$.subscribe((result) => { this.teamCollectionUpdated$ = teamCollUpdated$.subscribe((result) => {
if (E.isLeft(result)) if (E.isLeft(result))
throw new Error(`Team Collection Updated Error: ${result.left}`) throw new Error(
`Team Collection Updated Error: ${JSON.stringify(result.left)}`
)
this.updateCollection({ this.updateCollection({
id: result.right.teamCollectionUpdated.id, id: result.right.teamCollectionUpdated.id,
@@ -511,7 +515,9 @@ export default class NewTeamCollectionAdapter {
this.teamCollectionRemovedSub = teamCollRemovedSub this.teamCollectionRemovedSub = teamCollRemovedSub
this.teamCollectionRemoved$ = teamCollRemoved$.subscribe((result) => { this.teamCollectionRemoved$ = teamCollRemoved$.subscribe((result) => {
if (E.isLeft(result)) if (E.isLeft(result))
throw new Error(`Team Collection Removed Error: ${result.left}`) throw new Error(
`Team Collection Removed Error: ${JSON.stringify(result.left)}`
)
this.removeCollection(result.right.teamCollectionRemoved) this.removeCollection(result.right.teamCollectionRemoved)
}) })
@@ -526,7 +532,9 @@ export default class NewTeamCollectionAdapter {
this.teamRequestAddedSub = teamReqAddedSub this.teamRequestAddedSub = teamReqAddedSub
this.teamRequestAdded$ = teamReqAdded$.subscribe((result) => { this.teamRequestAdded$ = teamReqAdded$.subscribe((result) => {
if (E.isLeft(result)) if (E.isLeft(result))
throw new Error(`Team Request Added Error: ${result.left}`) throw new Error(
`Team Request Added Error: ${JSON.stringify(result.left)}`
)
this.addRequest({ this.addRequest({
id: result.right.teamRequestAdded.id, id: result.right.teamRequestAdded.id,
@@ -548,7 +556,9 @@ export default class NewTeamCollectionAdapter {
this.teamRequestUpdatedSub = teamReqUpdatedSub this.teamRequestUpdatedSub = teamReqUpdatedSub
this.teamRequestUpdated$ = teamReqUpdated$.subscribe((result) => { this.teamRequestUpdated$ = teamReqUpdated$.subscribe((result) => {
if (E.isLeft(result)) if (E.isLeft(result))
throw new Error(`Team Request Updated Error: ${result.left}`) throw new Error(
`Team Request Updated Error: ${JSON.stringify(result.left)}`
)
this.updateRequest({ this.updateRequest({
id: result.right.teamRequestUpdated.id, id: result.right.teamRequestUpdated.id,
@@ -568,7 +578,9 @@ export default class NewTeamCollectionAdapter {
this.teamRequestUpdatedSub = teamReqDeleted this.teamRequestUpdatedSub = teamReqDeleted
this.teamRequestDeleted$ = teamReqDeleted$.subscribe((result) => { this.teamRequestDeleted$ = teamReqDeleted$.subscribe((result) => {
if (E.isLeft(result)) if (E.isLeft(result))
throw new Error(`Team Request Deleted Error ${result.left}`) throw new Error(
`Team Request Deleted Error ${JSON.stringify(result.left)}`
)
this.removeRequest(result.right.teamRequestDeleted) this.removeRequest(result.right.teamRequestDeleted)
}) })

4
packages/hoppscotch-app/src/helpers/teams/TeamListAdapter.ts
View File

@@ -65,7 +65,9 @@ export default class TeamListAdapter {
if (E.isLeft(result)) { if (E.isLeft(result)) {
this.error$.next(result.left) this.error$.next(result.left)
throw new Error(`Failed fetching teams list: ${result.left}`) throw new Error(
`Failed fetching teams list: ${JSON.stringify(result.left)}`
)
} }
results.push(...result.right.myTeams) results.push(...result.right.myTeams)