From 90c9f2a9b16bc15ed736bf0031ce0f780f899b79 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Sun, 28 Apr 2024 17:06:26 +0530 Subject: [PATCH] fix: make writable handle operate on refs within the `createRESTRequest` method Wrap the request handle data in a `ref` and make the writable handle operate over it ensuring reactive updates are received. --- .../providers/personal.workspace.ts | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/packages/hoppscotch-common/src/services/new-workspace/providers/personal.workspace.ts b/packages/hoppscotch-common/src/services/new-workspace/providers/personal.workspace.ts index d4fc24658..d9cb5542e 100644 --- a/packages/hoppscotch-common/src/services/new-workspace/providers/personal.workspace.ts +++ b/packages/hoppscotch-common/src/services/new-workspace/providers/personal.workspace.ts @@ -350,6 +350,17 @@ export class PersonalWorkspaceProviderService platform: "rest", }) + const handleRefData = ref({ + type: "ok" as const, + data: { + providerID, + workspaceID, + collectionID, + requestID, + request: newRequest, + }, + }) + const handle: HandleRef = computed(() => { if ( !isValidCollectionHandle( @@ -364,24 +375,15 @@ export class PersonalWorkspaceProviderService } } - return { - type: "ok", - data: { - providerID, - workspaceID, - collectionID, - requestID, - request: newRequest, - }, - } + return handleRefData.value }) const writableHandle = computed({ get() { - return handle.value + return handleRefData.value }, set(newValue) { - handle.value = newValue + handleRefData.value = newValue }, })