From 822e7b4630ab544c0893af0d39bba161c2f658c8 Mon Sep 17 00:00:00 2001
From: liyasthomas <liyascthomas@gmail.com>
Date: Fri, 20 Aug 2021 21:35:54 +0530
Subject: [PATCH] refactor: improve lighthouse score

---
 assets/scss/styles.scss               | 14 +++++++-------
 components/collections/ChooseType.vue |  1 +
 components/firebase/Login.vue         |  4 ++--
 components/http/PreRequestScript.vue  |  2 +-
 components/http/Tests.vue             |  2 +-
 components/smart/Tabs.vue             |  2 +-
 components/teams/Edit.vue             | 16 ++++++++++++++--
 locales/en.json                       |  2 ++
 8 files changed, 29 insertions(+), 14 deletions(-)

diff --git a/assets/scss/styles.scss b/assets/scss/styles.scss
index 6fce38aa5..3fee3b45c 100644
--- a/assets/scss/styles.scss
+++ b/assets/scss/styles.scss
@@ -253,6 +253,7 @@ pre.ace_editor {
 
 .select {
   @apply appearance-none;
+  @apply cursor-pointer;
 
   &::-ms-expand {
     @apply hidden;
@@ -262,7 +263,6 @@ pre.ace_editor {
 .select-wrapper {
   @apply flex flex-1;
   @apply relative;
-  @apply cursor-pointer;
 
   &::after {
     @apply absolute;
@@ -449,15 +449,15 @@ input[type="checkbox"] {
 }
 
 .splitpanes--vertical > .splitpanes__splitter::before {
-  left: -2px;
-  right: -2px;
-  height: 100%;
+  @apply -left-0.5;
+  @apply -right-0.5;
+  @apply h-full;
 }
 
 .splitpanes--horizontal > .splitpanes__splitter::before {
-  top: -2px;
-  bottom: -2px;
-  width: 100%;
+  @apply -top-0.5;
+  @apply -bottom-0.5;
+  @apply w-full;
 }
 
 @media (max-width: 767px) {
diff --git a/components/collections/ChooseType.vue b/components/collections/ChooseType.vue
index 53c67667a..05bb164fe 100644
--- a/components/collections/ChooseType.vue
+++ b/components/collections/ChooseType.vue
@@ -20,6 +20,7 @@
               class="
                 bg-primaryLight
                 border-b border-dividerLight
+                cursor-pointer
                 flex
                 w-full
                 py-2
diff --git a/components/firebase/Login.vue b/components/firebase/Login.vue
index 0ea3c3d9e..d16ccc791 100644
--- a/components/firebase/Login.vue
+++ b/components/firebase/Login.vue
@@ -95,7 +95,7 @@
       <p v-if="mode === 'email'" class="text-secondaryLight">
         <SmartAnchor
           class="link"
-          :label="`← ${$t('auth.all_sign_in_options')}`"
+          :label="`← \xA0 ${$t('auth.all_sign_in_options')}`"
           @click.native="mode = 'sign-in'"
         />
       </p>
@@ -105,7 +105,7 @@
       >
         <SmartAnchor
           class="link"
-          :label="`← ${$t('auth.re_enter_email')}`"
+          :label="`← \xA0 ${$t('auth.re_enter_email')}`"
           @click.native="mode = 'email'"
         />
         <SmartAnchor
diff --git a/components/http/PreRequestScript.vue b/components/http/PreRequestScript.vue
index 7231dfc14..43e720b19 100644
--- a/components/http/PreRequestScript.vue
+++ b/components/http/PreRequestScript.vue
@@ -63,7 +63,7 @@
         </div>
         <SmartAnchor
           class="link"
-          :label="$t('action.learn_more')"
+          :label="`${$t('preRequest.learn')} \xA0 →`"
           to="https://docs.hoppscotch.io/features/pre-request-script"
           blank
         />
diff --git a/components/http/Tests.vue b/components/http/Tests.vue
index b894dd1e6..7bcd393dc 100644
--- a/components/http/Tests.vue
+++ b/components/http/Tests.vue
@@ -63,7 +63,7 @@
         </div>
         <SmartAnchor
           class="link"
-          :label="$t('action.learn_more')"
+          :label="`${$t('test.learn')} \xA0 →`"
           to="https://docs.hoppscotch.io/features/tests"
           blank
         />
diff --git a/components/smart/Tabs.vue b/components/smart/Tabs.vue
index 20594e662..8350c8b60 100644
--- a/components/smart/Tabs.vue
+++ b/components/smart/Tabs.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="flex flex-col flex-nowrap flex-1">
-    <div class="tabs hide-scrollbar relative" :class="styles">
+    <div class="rounded-t tabs hide-scrollbar relative" :class="styles">
       <div class="flex w-0">
         <div class="inline-flex">
           <button
diff --git a/components/teams/Edit.vue b/components/teams/Edit.vue
index 18a041a3c..545c0fd4b 100644
--- a/components/teams/Edit.vue
+++ b/components/teams/Edit.vue
@@ -52,7 +52,13 @@
                 <template #trigger>
                   <span class="select-wrapper">
                     <input
-                      class="bg-primaryLight flex flex-1 py-2 px-4"
+                      class="
+                        bg-primaryLight
+                        cursor-pointer
+                        flex flex-1
+                        py-2
+                        px-4
+                      "
                       :placeholder="$t('team.permissions')"
                       :name="'value' + index"
                       :value="
@@ -112,7 +118,13 @@
                 <template #trigger>
                   <span class="select-wrapper">
                     <input
-                      class="bg-primaryLight flex flex-1 py-2 px-4"
+                      class="
+                        bg-primaryLight
+                        cursor-pointer
+                        flex flex-1
+                        py-2
+                        px-4
+                      "
                       :placeholder="$t('team.permissions')"
                       :name="'value' + index"
                       :value="
diff --git a/locales/en.json b/locales/en.json
index cd1c801f3..0b2e733ff 100644
--- a/locales/en.json
+++ b/locales/en.json
@@ -246,6 +246,7 @@
   },
   "preRequest": {
     "javascript_code": "JavaScript Code",
+    "learn": "Learn how to write pre-request scripts",
     "script": "Pre-Request Script",
     "snippets": "Snippets"
   },
@@ -475,6 +476,7 @@
   },
   "test": {
     "javascript_code": "JavaScript Code",
+    "learn": "Learn how to write test scripts",
     "report": "Test Report",
     "results": "Test Results",
     "script": "Script",