From 7da5063a8c9c26b21c859f039dfd2334ce0f8efb Mon Sep 17 00:00:00 2001 From: Mir Arif Hasan Date: Mon, 11 Dec 2023 17:22:48 +0600 Subject: [PATCH] chore: feedback resolve --- .../src/infra-config/infra-config.service.ts | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts b/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts index 4ee891d6c..d2402ae64 100644 --- a/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts +++ b/packages/hoppscotch-backend/src/infra-config/infra-config.service.ts @@ -293,14 +293,17 @@ export class InfraConfigService implements OnModuleInit { }[], ) { for (let i = 0; i < infraConfigs.length; i++) { - if (infraConfigs[i].name === InfraConfigEnumForClient.MAILER_SMTP_URL) { - const isValidUrl = validateSMTPUrl(infraConfigs[i].value); - if (!isValidUrl) return E.left(INFRA_CONFIG_INVALID_INPUT); - } else if ( - infraConfigs[i].name === InfraConfigEnumForClient.MAILER_ADDRESS_FROM - ) { - const isValidEmail = validateEmail(infraConfigs[i].value); - if (!isValidEmail) return E.left(INFRA_CONFIG_INVALID_INPUT); + switch (infraConfigs[i].name) { + case InfraConfigEnumForClient.MAILER_SMTP_URL: + const isValidUrl = validateSMTPUrl(infraConfigs[i].value); + if (!isValidUrl) return E.left(INFRA_CONFIG_INVALID_INPUT); + break; + case InfraConfigEnumForClient.MAILER_ADDRESS_FROM: + const isValidEmail = validateEmail(infraConfigs[i].value); + if (!isValidEmail) return E.left(INFRA_CONFIG_INVALID_INPUT); + break; + default: + break; } }