From 7c5722586c916617812cdcec1342ee3f7c84378c Mon Sep 17 00:00:00 2001
From: Andrew Bastin <andrewbastin.k@gmail.com>
Date: Wed, 5 Jul 2023 11:51:15 +0530
Subject: [PATCH] refactor: move shortcuts to use minisearch

---
 .../hoppscotch-common/src/components.d.ts     |   1 -
 .../src/components/app/Shortcuts.vue          |  79 ++-
 .../src/components/app/ShortcutsEntry.vue     |  11 +-
 .../src/helpers/shortcuts.ts                  | 453 ++++++------------
 4 files changed, 180 insertions(+), 364 deletions(-)

diff --git a/packages/hoppscotch-common/src/components.d.ts b/packages/hoppscotch-common/src/components.d.ts
index a9d66d3d9..7b3dc31d2 100644
--- a/packages/hoppscotch-common/src/components.d.ts
+++ b/packages/hoppscotch-common/src/components.d.ts
@@ -131,7 +131,6 @@ declare module '@vue/runtime-core' {
     IconLucideLayers: typeof import('~icons/lucide/layers')['default']
     IconLucideListEnd: typeof import('~icons/lucide/list-end')['default']
     IconLucideMinus: typeof import('~icons/lucide/minus')['default']
-    IconLucideRefreshCcw: typeof import('~icons/lucide/refresh-ccw')['default']
     IconLucideRefreshCw: typeof import('~icons/lucide/refresh-cw')['default']
     IconLucideSearch: typeof import('~icons/lucide/search')['default']
     IconLucideUsers: typeof import('~icons/lucide/users')['default']
diff --git a/packages/hoppscotch-common/src/components/app/Shortcuts.vue b/packages/hoppscotch-common/src/components/app/Shortcuts.vue
index 0f367416b..4d8006b00 100644
--- a/packages/hoppscotch-common/src/components/app/Shortcuts.vue
+++ b/packages/hoppscotch-common/src/components/app/Shortcuts.vue
@@ -14,46 +14,18 @@
           />
         </div>
       </div>
-      <div v-if="filterText" class="flex flex-col divide-y divide-dividerLight">
-        <details
-          v-for="(map, mapIndex) in searchResults"
-          :key="`map-${mapIndex}`"
-          class="flex flex-col"
-          open
-        >
-          <summary
-            class="flex items-center flex-1 min-w-0 px-6 py-4 font-semibold transition cursor-pointer focus:outline-none text-secondaryLight hover:text-secondaryDark"
-          >
-            <icon-lucide-chevron-right class="mr-2 indicator" />
-            <span
-              class="font-semibold truncate capitalize-first text-secondaryDark"
-            >
-              {{ t(map.item.section) }}
-            </span>
-          </summary>
-          <div class="flex flex-col px-6 pb-4 space-y-2">
-            <AppShortcutsEntry
-              v-for="(shortcut, index) in map.item.shortcuts"
-              :key="`shortcut-${index}`"
-              :shortcut="shortcut"
-            />
-          </div>
-        </details>
-        <HoppSmartPlaceholder
-          v-if="searchResults.length === 0"
-          :text="`${t('state.nothing_found')} ‟${filterText}”`"
-        >
+      <div class="flex flex-col divide-y divide-dividerLight">
+        <HoppSmartPlaceholder v-if="isEmpty(shortcutsResults)">
           <icon-lucide-search class="pb-2 opacity-75 svg-icons" />
           <span class="my-2 text-center flex flex-col">
             {{ t("state.nothing_found") }}
             <span class="break-all">"{{ filterText }}"</span>
           </span>
         </HoppSmartPlaceholder>
-      </div>
-      <div v-else class="flex flex-col divide-y divide-dividerLight">
         <details
-          v-for="(map, mapIndex) in mappings"
-          :key="`map-${mapIndex}`"
+          v-for="(sectionResults, sectionTitle) in shortcutsResults"
+          v-else
+          :key="`section-${sectionTitle}`"
           class="flex flex-col"
           open
         >
@@ -64,13 +36,13 @@
             <span
               class="font-semibold truncate capitalize-first text-secondaryDark"
             >
-              {{ t(map.section) }}
+              {{ sectionTitle }}
             </span>
           </summary>
           <div class="flex flex-col px-6 pb-4 space-y-2">
             <AppShortcutsEntry
-              v-for="(shortcut, shortcutIndex) in map.shortcuts"
-              :key="`map-${mapIndex}-shortcut-${shortcutIndex}`"
+              v-for="(shortcut, index) in sectionResults"
+              :key="`shortcut-${index}`"
               :shortcut="shortcut"
             />
           </div>
@@ -81,10 +53,11 @@
 </template>
 
 <script setup lang="ts">
-import { computed, ref } from "vue"
-import Fuse from "fuse.js"
-import mappings from "~/helpers/shortcuts"
+import { computed, onBeforeMount, ref } from "vue"
+import { ShortcutDef, getShortcuts } from "~/helpers/shortcuts"
+import MiniSearch from "minisearch"
 import { useI18n } from "@composables/i18n"
+import { groupBy, isEmpty } from "lodash-es"
 
 const t = useI18n()
 
@@ -92,15 +65,33 @@ defineProps<{
   show: boolean
 }>()
 
-const options = {
-  keys: ["shortcuts.label"],
-}
+const minisearch = new MiniSearch({
+  fields: ["label", "keys", "section"],
+  idField: "label",
+  storeFields: ["label", "keys", "section"],
+  searchOptions: {
+    fuzzy: true,
+    prefix: true,
+  },
+})
 
-const fuse = new Fuse(mappings, options)
+const shortcuts = getShortcuts(t)
+
+onBeforeMount(() => {
+  minisearch.addAllAsync(shortcuts)
+})
 
 const filterText = ref("")
 
-const searchResults = computed(() => fuse.search(filterText.value))
+const shortcutsResults = computed(() => {
+  // If there are no search text, return all the shortcuts
+  const results =
+    filterText.value.length > 0
+      ? minisearch.search(filterText.value)
+      : shortcuts
+
+  return groupBy(results, "section") as Record<string, ShortcutDef[]>
+})
 
 const emit = defineEmits<{
   (e: "close"): void
diff --git a/packages/hoppscotch-common/src/components/app/ShortcutsEntry.vue b/packages/hoppscotch-common/src/components/app/ShortcutsEntry.vue
index 2dee8d034..3d61218ed 100644
--- a/packages/hoppscotch-common/src/components/app/ShortcutsEntry.vue
+++ b/packages/hoppscotch-common/src/components/app/ShortcutsEntry.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="flex items-center py-1">
     <span class="flex flex-1 mr-4">
-      {{ t(shortcut.label) }}
+      {{ shortcut.label }}
     </span>
     <kbd
       v-for="(key, index) in shortcut.keys"
@@ -14,14 +14,9 @@
 </template>
 
 <script setup lang="ts">
-import { useI18n } from "@composables/i18n"
-
-const t = useI18n()
+import { ShortcutDef } from "~/helpers/shortcuts"
 
 defineProps<{
-  shortcut: {
-    label: string
-    keys: string[]
-  }
+  shortcut: ShortcutDef
 }>()
 </script>
diff --git a/packages/hoppscotch-common/src/helpers/shortcuts.ts b/packages/hoppscotch-common/src/helpers/shortcuts.ts
index 67c31d2b7..73af38270 100644
--- a/packages/hoppscotch-common/src/helpers/shortcuts.ts
+++ b/packages/hoppscotch-common/src/helpers/shortcuts.ts
@@ -1,315 +1,146 @@
-import IconLifeBuoy from "~icons/lucide/life-buoy"
-import IconZap from "~icons/lucide/zap"
-import IconArrowRight from "~icons/lucide/arrow-right"
-import IconGift from "~icons/lucide/gift"
-import IconMonitor from "~icons/lucide/monitor"
-import IconSun from "~icons/lucide/sun"
-import IconCloud from "~icons/lucide/cloud"
-import IconMoon from "~icons/lucide/moon"
 import { getPlatformAlternateKey, getPlatformSpecialKey } from "./platformutils"
 
-export default [
-  {
-    section: "shortcut.general.title",
-    shortcuts: [
-      {
-        keys: ["?"],
-        label: "shortcut.general.help_menu",
-      },
-      {
-        keys: ["/"],
-        label: "shortcut.general.command_menu",
-      },
-      {
-        keys: [getPlatformSpecialKey(), "K"],
-        label: "shortcut.general.show_all",
-      },
-      {
-        keys: ["ESC"],
-        label: "shortcut.general.close_current_menu",
-      },
-    ],
-  },
-  {
-    section: "shortcut.request.title",
-    shortcuts: [
-      {
-        keys: [getPlatformSpecialKey(), "↩"],
-        label: "shortcut.request.send_request",
-      },
-      {
-        keys: [getPlatformSpecialKey(), "S"],
-        label: "shortcut.request.save_to_collections",
-      },
-      {
-        keys: [getPlatformSpecialKey(), "U"],
-        label: "shortcut.request.copy_request_link",
-      },
-      {
-        keys: [getPlatformSpecialKey(), "I"],
-        label: "shortcut.request.reset_request",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "↑"],
-        label: "shortcut.request.next_method",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "↓"],
-        label: "shortcut.request.previous_method",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "G"],
-        label: "shortcut.request.get_method",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "H"],
-        label: "shortcut.request.head_method",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "P"],
-        label: "shortcut.request.post_method",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "U"],
-        label: "shortcut.request.put_method",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "X"],
-        label: "shortcut.request.delete_method",
-      },
-    ],
-  },
-  {
-    section: "shortcut.response.title",
-    shortcuts: [
-      {
-        keys: [getPlatformSpecialKey(), "J"],
-        label: "shortcut.response.download",
-      },
-      {
-        keys: [getPlatformSpecialKey(), "."],
-        label: "shortcut.response.copy",
-      },
-    ],
-  },
-  {
-    section: "shortcut.navigation.title",
-    shortcuts: [
-      {
-        keys: [getPlatformSpecialKey(), "←"],
-        label: "shortcut.navigation.back",
-      },
-      {
-        keys: [getPlatformSpecialKey(), "→"],
-        label: "shortcut.navigation.forward",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "R"],
-        label: "shortcut.navigation.rest",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "Q"],
-        label: "shortcut.navigation.graphql",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "W"],
-        label: "shortcut.navigation.realtime",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "S"],
-        label: "shortcut.navigation.settings",
-      },
-      {
-        keys: [getPlatformAlternateKey(), "M"],
-        label: "shortcut.navigation.profile",
-      },
-    ],
-  },
-  {
-    section: "shortcut.miscellaneous.title",
-    shortcuts: [
-      {
-        keys: [getPlatformSpecialKey(), "M"],
-        label: "shortcut.miscellaneous.invite",
-      },
-    ],
-  },
-]
+export type ShortcutDef = {
+  label: string
+  keys: string[]
+  section: string
+}
 
-export const spotlight = [
-  {
-    section: "app.spotlight",
-    shortcuts: [
-      {
-        keys: ["?"],
-        label: "shortcut.general.help_menu",
-        action: "modals.support.toggle",
-        icon: IconLifeBuoy,
-      },
-      {
-        keys: [getPlatformSpecialKey(), "K"],
-        label: "shortcut.general.show_all",
-        action: "flyouts.keybinds.toggle",
-        icon: IconZap,
-      },
-    ],
-  },
-  {
-    section: "shortcut.navigation.title",
-    shortcuts: [
-      {
-        keys: [getPlatformAlternateKey(), "R"],
-        label: "shortcut.navigation.rest",
-        action: "navigation.jump.rest",
-        icon: IconArrowRight,
-      },
-      {
-        keys: [getPlatformAlternateKey(), "Q"],
-        label: "shortcut.navigation.graphql",
-        action: "navigation.jump.graphql",
-        icon: IconArrowRight,
-      },
-      {
-        keys: [getPlatformAlternateKey(), "W"],
-        label: "shortcut.navigation.realtime",
-        action: "navigation.jump.realtime",
-        icon: IconArrowRight,
-      },
-      {
-        keys: [getPlatformAlternateKey(), "S"],
-        label: "shortcut.navigation.settings",
-        action: "navigation.jump.settings",
-        icon: IconArrowRight,
-      },
-      {
-        keys: [getPlatformAlternateKey(), "M"],
-        label: "shortcut.navigation.profile",
-        action: "navigation.jump.profile",
-        icon: IconArrowRight,
-      },
-    ],
-  },
-  {
-    section: "shortcut.miscellaneous.title",
-    shortcuts: [
-      {
-        keys: [getPlatformSpecialKey(), "M"],
-        label: "shortcut.miscellaneous.invite",
-        action: "modals.share.toggle",
-        icon: IconGift,
-      },
-    ],
-  },
-]
+export function getShortcuts(t: (x: string) => string): ShortcutDef[] {
+  // General
+  return [
+    {
+      label: t("shortcut.general.help_menu"),
+      keys: ["?"],
+      section: t("shortcut.general.title"),
+    },
+    {
+      label: t("shortcut.general.command_menu"),
+      keys: ["/"],
+      section: t("shortcut.general.title"),
+    },
+    {
+      label: t("shortcut.general.show_all"),
+      keys: [getPlatformSpecialKey(), "K"],
+      section: t("shortcut.general.title"),
+    },
+    {
+      label: t("shortcut.general.close_current_menu"),
+      keys: ["ESC"],
+      section: t("shortcut.general.title"),
+    },
 
-export const fuse = [
-  {
-    keys: ["?"],
-    label: "shortcut.general.help_menu",
-    action: "modals.support.toggle",
-    icon: IconLifeBuoy,
-    tags: [
-      "help",
-      "support",
-      "menu",
-      "discord",
-      "twitter",
-      "documentation",
-      "troubleshooting",
-      "chat",
-      "community",
-      "feedback",
-      "report",
-      "bug",
-      "issue",
-      "ticket",
-    ],
-  },
-  {
-    keys: [getPlatformSpecialKey(), "K"],
-    label: "shortcut.general.show_all",
-    action: "flyouts.keybinds.toggle",
-    icon: IconZap,
-    tags: ["keyboard", "shortcuts"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "R"],
-    label: "shortcut.navigation.rest",
-    action: "navigation.jump.rest",
-    icon: IconArrowRight,
-    tags: ["rest", "jump", "page", "navigation", "go"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "Q"],
-    label: "shortcut.navigation.graphql",
-    action: "navigation.jump.graphql",
-    icon: IconArrowRight,
-    tags: ["graphql", "jump", "page", "navigation", "go"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "W"],
-    label: "shortcut.navigation.realtime",
-    action: "navigation.jump.realtime",
-    icon: IconArrowRight,
-    tags: [
-      "realtime",
-      "jump",
-      "page",
-      "navigation",
-      "websocket",
-      "socket",
-      "mqtt",
-      "sse",
-      "go",
-    ],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "S"],
-    label: "shortcut.navigation.settings",
-    action: "navigation.jump.settings",
-    icon: IconArrowRight,
-    tags: ["settings", "jump", "page", "navigation", "account", "theme", "go"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "M"],
-    label: "shortcut.navigation.profile",
-    action: "navigation.jump.profile",
-    icon: IconArrowRight,
-    tags: ["profile", "jump", "page", "navigation", "account", "theme", "go"],
-  },
-  {
-    keys: [getPlatformSpecialKey(), "M"],
-    label: "shortcut.miscellaneous.invite",
-    action: "modals.share.toggle",
-    icon: IconGift,
-    tags: ["invite", "share", "app", "friends", "people", "social"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "0"],
-    label: "shortcut.theme.system",
-    action: "settings.theme.system",
-    icon: IconMonitor,
-    tags: ["theme", "system"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "1"],
-    label: "shortcut.theme.light",
-    action: "settings.theme.light",
-    icon: IconSun,
-    tags: ["theme", "light"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "2"],
-    label: "shortcut.theme.dark",
-    action: "settings.theme.dark",
-    icon: IconCloud,
-    tags: ["theme", "dark"],
-  },
-  {
-    keys: [getPlatformAlternateKey(), "3"],
-    label: "shortcut.theme.black",
-    action: "settings.theme.black",
-    icon: IconMoon,
-    tags: ["theme", "black"],
-  },
-]
+    // Request
+    {
+      label: t("shortcut.request.send_request"),
+      keys: [getPlatformSpecialKey(), "↩"],
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformSpecialKey(), "S"],
+      label: t("shortcut.request.save_to_collections"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformSpecialKey(), "U"],
+      label: t("shortcut.request.copy_request_link"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformSpecialKey(), "I"],
+      label: t("shortcut.request.reset_request"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "↑"],
+      label: t("shortcut.request.next_method"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "↓"],
+      label: t("shortcut.request.previous_method"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "G"],
+      label: t("shortcut.request.get_method"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "H"],
+      label: t("shortcut.request.head_method"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "P"],
+      label: t("shortcut.request.post_method"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "U"],
+      label: t("shortcut.request.put_method"),
+      section: t("shortcut.request.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "X"],
+      label: t("shortcut.request.delete_method"),
+      section: t("shortcut.request.title"),
+    },
+
+    // Response
+    {
+      keys: [getPlatformSpecialKey(), "J"],
+      label: t("shortcut.response.download"),
+      section: t("shortcut.response.title"),
+    },
+    {
+      keys: [getPlatformSpecialKey(), "."],
+      label: t("shortcut.response.copy"),
+      section: t("shortcut.response.title"),
+    },
+
+    // Navigation
+    {
+      keys: [getPlatformSpecialKey(), "←"],
+      label: t("shortcut.navigation.back"),
+      section: t("shortcut.navigation.title"),
+    },
+    {
+      keys: [getPlatformSpecialKey(), "→"],
+      label: t("shortcut.navigation.forward"),
+      section: t("shortcut.navigation.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "R"],
+      label: t("shortcut.navigation.rest"),
+      section: t("shortcut.navigation.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "Q"],
+      label: t("shortcut.navigation.graphql"),
+      section: t("shortcut.navigation.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "W"],
+      label: t("shortcut.navigation.realtime"),
+      section: t("shortcut.navigation.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "S"],
+      label: t("shortcut.navigation.settings"),
+      section: t("shortcut.navigation.title"),
+    },
+    {
+      keys: [getPlatformAlternateKey(), "M"],
+      label: t("shortcut.navigation.profile"),
+      section: t("shortcut.navigation.title"),
+    },
+
+    // Miscellaneous
+    {
+      keys: [getPlatformSpecialKey(), "M"],
+      label: t("shortcut.miscellaneous.invite"),
+      section: t("shortcut.miscellaneous.title"),
+    },
+  ]
+}