From 6ed4b73a34c5f4a1cec215f23f7312adee9b759c Mon Sep 17 00:00:00 2001
From: nivedin <nivedinp@gmail.com>
Date: Fri, 29 Dec 2023 19:55:22 +0530
Subject: [PATCH] chore: code refactor

---
 .../hoppscotch-common/src/pages/e/_id.vue     | 43 ++++++-------------
 1 file changed, 13 insertions(+), 30 deletions(-)

diff --git a/packages/hoppscotch-common/src/pages/e/_id.vue b/packages/hoppscotch-common/src/pages/e/_id.vue
index 09545d8fb..46933bd29 100644
--- a/packages/hoppscotch-common/src/pages/e/_id.vue
+++ b/packages/hoppscotch-common/src/pages/e/_id.vue
@@ -19,39 +19,22 @@
       :shared-request-i-d="sharedRequestID"
     />
     <div v-else class="flex flex-1 flex-col items-center justify-center p-4">
+      <HoppSmartSpinner v-if="sharedRequestDetails.loading" />
       <div
-        v-if="sharedRequestDetails.loading"
-        class="flex flex-1 flex-col items-center justify-center p-4"
+        v-else-if="E.isLeft(sharedRequestDetails.data)"
+        class="flex flex-col items-center"
       >
-        <HoppSmartSpinner />
-      </div>
-      <div v-else>
-        <div
-          v-if="
-            !sharedRequestDetails.loading && E.isLeft(sharedRequestDetails.data)
-          "
-          class="flex flex-col items-center p-4"
-        >
-          <icon-lucide-alert-triangle class="svg-icons mb-2 opacity-75" />
-          <h1 class="heading text-center">
-            {{ t("error.invalid_link") }}
-          </h1>
-          <p class="mt-2 text-center">
-            {{ t("error.invalid_embed_link") }}
-          </p>
-        </div>
-        <div
-          v-if="
-            !sharedRequestDetails.loading &&
-            E.isRight(sharedRequestDetails.data)
-          "
-          class="flex flex-1 flex-col items-center justify-center p-4"
-        >
-          <h1 class="heading">
-            {{ t("state.loading") }}
-          </h1>
-        </div>
+        <icon-lucide-alert-triangle class="svg-icons mb-2 opacity-75" />
+        <h1 class="heading text-center">
+          {{ t("error.invalid_link") }}
+        </h1>
+        <p class="mt-2 text-center">
+          {{ t("error.invalid_embed_link") }}
+        </p>
       </div>
+      <h1 v-if="E.isRight(sharedRequestDetails.data)" class="heading">
+        {{ t("state.loading") }}
+      </h1>
     </div>
   </div>
 </template>