From 6bcd53276787303801c611afbc758142e1327cef Mon Sep 17 00:00:00 2001
From: Liyas Thomas <liyascthomas@gmail.com>
Date: Wed, 22 Jan 2020 12:47:09 +0530
Subject: [PATCH] :bug: Fixed error on Download feed

---
 components/firebase/feeds.vue | 9 ++++-----
 functions/fb.js               | 5 +++--
 pages/settings.vue            | 8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/components/firebase/feeds.vue b/components/firebase/feeds.vue
index dd1715a42..89bd4c1fc 100644
--- a/components/firebase/feeds.vue
+++ b/components/firebase/feeds.vue
@@ -59,13 +59,12 @@ export default {
   methods: {
     deleteFeed(feed) {
       fb.deleteFeed(feed.id);
+      this.$toast.error(this.$t("deleted"), {
+        icon: "delete"
+      });
     },
     saveFeed(feed) {
-      const dataToWrite = JSON.stringify(
-        eval("(" + feed.message + ")"),
-        null,
-        2
-      );
+      const dataToWrite = JSON.stringify(feed.message, null, 2);
       const file = new Blob([dataToWrite], { type: "application/json" });
       const a = document.createElement("a"),
         url = URL.createObjectURL(file);
diff --git a/functions/fb.js b/functions/fb.js
index 9fa838363..a9fa957fc 100644
--- a/functions/fb.js
+++ b/functions/fb.js
@@ -40,11 +40,12 @@ export const fb = {
       return console.error("error inserting", dt, e);
     }
   },
-  deleteFeed: id =>
+  deleteFeed: id => {
     feedsCollection
       .doc(id)
       .delete()
-      .catch(e => console.error("error deleting", dt, e)),
+      .catch(e => console.error("error deleting", dt, e));
+  },
   writeSettings: async (setting, value) => {
     const st = {
       updatedOn: new Date(),
diff --git a/pages/settings.vue b/pages/settings.vue
index c6160da37..4a26bbe0e 100644
--- a/pages/settings.vue
+++ b/pages/settings.vue
@@ -6,7 +6,7 @@
           <div v-if="!fb.currentUser">
             <label>{{ $t("login_with") }}</label>
             <p>
-              <button class="icon" @click="signInWithGoogle" v-close-popover>
+              <button class="icon" @click="signInWithGoogle">
                 <svg
                   xmlns="http://www.w3.org/2000/svg"
                   width="24"
@@ -21,7 +21,7 @@
                 <span>Google</span>
               </button>
               <br />
-              <button class="icon" @click="signInWithGithub" v-close-popover>
+              <button class="icon" @click="signInWithGithub">
                 <svg
                   xmlns="http://www.w3.org/2000/svg"
                   width="24"
@@ -57,12 +57,12 @@
               </span>
             </button>
             <br />
-            <button class="icon" @click="logout" v-close-popover>
+            <button class="icon" @click="logout">
               <i class="material-icons">exit_to_app</i>
               <span>{{ $t("logout") }}</span>
             </button>
             <br />
-            <p v-for="setting in fb.currentSettings">
+            <p v-for="setting in fb.currentSettings" :key="setting.id">
               <pw-toggle
                 :key="setting.name"
                 :on="setting.value"