btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Fix auto scroll

Browse Source 
Wasn't actually working with the last PR. This one fixes it.
This commit is contained in:
Dmitry Yankowski
2020-02-25 00:32:03 -05:00
parent 7c23cd7c4c
commit 62a970e8c3
2 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pages/graphql.vue
View File

@@ -346,6 +346,14 @@ export default {
doneButton: '<i class="material-icons">done</i>', doneButton: '<i class="material-icons">done</i>',
expandResponse: false, expandResponse: false,
responseBodyMaxLines: 16, responseBodyMaxLines: 16,
settings: {
SCROLL_INTO_ENABLED:
typeof this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED !==
"undefined"
? this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED
: true,
}
} }
}, },
@@ -417,7 +425,7 @@ export default {
const rootTypeName = this.resolveRootType(type).name const rootTypeName = this.resolveRootType(type).name
const target = document.getElementById(`type_${rootTypeName}`) const target = document.getElementById(`type_${rootTypeName}`)
if (target && this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED) { if (target && this.settings.SCROLL_INTO_ENABLED) {
target.scrollIntoView({ target.scrollIntoView({
behavior: "smooth", behavior: "smooth",
}) })
@@ -472,7 +480,7 @@ export default {
this.$nuxt.$loading.start() this.$nuxt.$loading.start()
this.response = this.$t("loading") this.response = this.$t("loading")
this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED && this.scrollInto("response") this.settings.SCROLL_INTO_ENABLED && this.scrollInto("response")
try { try {
let headers = {} let headers = {}
@@ -515,7 +523,7 @@ export default {
async getSchema() { async getSchema() {
const startTime = Date.now() const startTime = Date.now()
this.schema = this.$t("loading") this.schema = this.$t("loading")
this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED && this.scrollInto("schema") this.settings.SCROLL_INTO_ENABLED && this.scrollInto("schema")
// Start showing the loading bar as soon as possible. // Start showing the loading bar as soon as possible.
// The nuxt axios module will hide it when the request is made. // The nuxt axios module will hide it when the request is made.

16
pages/index.vue
View File

@@ -1518,7 +1518,15 @@ export default {
customMethod: false, customMethod: false,
files: [], files: [],
filenames: "", filenames: "",
navigatorShare: navigator.share navigatorShare: navigator.share,
settings: {
SCROLL_INTO_ENABLED:
typeof this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED !==
"undefined"
? this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED
: true
}
}; };
}, },
watch: { watch: {
@@ -2085,8 +2093,7 @@ export default {
this.path = path; this.path = path;
this.showPreRequestScript = usesScripts; this.showPreRequestScript = usesScripts;
this.preRequestScript = preRequestScript; this.preRequestScript = preRequestScript;
this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED && this.settings.SCROLL_INTO_ENABLED && this.scrollInto("request");
this.scrollInto("request");
}, },
getVariablesFromPreRequestScript() { getVariablesFromPreRequestScript() {
if (!this.preRequestScript) { if (!this.preRequestScript) {
@@ -2133,8 +2140,7 @@ export default {
}, },
async sendRequest() { async sendRequest() {
this.$toast.clear(); this.$toast.clear();
this.$store.state.postwoman.settings.SCROLL_INTO_ENABLED && this.settings.SCROLL_INTO_ENABLED && this.scrollInto("response");
this.scrollInto("response");
if (!this.isValidURL) { if (!this.isValidURL) {
this.$toast.error(this.$t("url_invalid_format"), { this.$toast.error(this.$t("url_invalid_format"), {