From 5eed5ce176cb9393a4b74d564da2a1292ecdcd85 Mon Sep 17 00:00:00 2001 From: mirarifhasan Date: Mon, 29 Apr 2024 22:33:11 +0600 Subject: [PATCH] refactor: getTeamMemberTE function removed --- .../hoppscotch-backend/src/admin/admin.service.ts | 6 +++--- .../hoppscotch-backend/src/team/team.service.ts | 13 ------------- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/packages/hoppscotch-backend/src/admin/admin.service.ts b/packages/hoppscotch-backend/src/admin/admin.service.ts index 08a3d5474..dfabc5c80 100644 --- a/packages/hoppscotch-backend/src/admin/admin.service.ts +++ b/packages/hoppscotch-backend/src/admin/admin.service.ts @@ -319,11 +319,11 @@ export class AdminService { const user = await this.userService.findUserByEmail(userEmail); if (O.isNone(user)) return E.left(USER_NOT_FOUND); - const teamMember = await this.teamService.getTeamMemberTE( + const teamMember = await this.teamService.getTeamMember( teamID, user.value.uid, - )(); - if (E.isLeft(teamMember)) { + ); + if (!teamMember) { const addedUser = await this.teamService.addMemberToTeamWithEmail( teamID, userEmail, diff --git a/packages/hoppscotch-backend/src/team/team.service.ts b/packages/hoppscotch-backend/src/team/team.service.ts index e4e23d73c..71c37ec7f 100644 --- a/packages/hoppscotch-backend/src/team/team.service.ts +++ b/packages/hoppscotch-backend/src/team/team.service.ts @@ -362,19 +362,6 @@ export class TeamService implements UserDataHandler, OnModuleInit { } } - getTeamMemberTE(teamID: string, userUid: string) { - return pipe( - () => this.getTeamMember(teamID, userUid), - TE.fromTask, - TE.chain( - TE.fromPredicate( - (x): x is TeamMember => !!x, - () => TEAM_MEMBER_NOT_FOUND, - ), - ), - ); - } - async getRoleOfUserInTeam( teamID: string, userUid: string,