From 58d3ef900fb48632f97183a60c632325893d7466 Mon Sep 17 00:00:00 2001
From: nivedin <nivedinp@gmail.com>
Date: Wed, 17 Jan 2024 20:31:29 +0530
Subject: [PATCH] refactor: minor code update

---
 .../hoppscotch-common/src/pages/e/_id.vue     | 25 ++++---------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/packages/hoppscotch-common/src/pages/e/_id.vue b/packages/hoppscotch-common/src/pages/e/_id.vue
index 46933bd29..ffc528c1b 100644
--- a/packages/hoppscotch-common/src/pages/e/_id.vue
+++ b/packages/hoppscotch-common/src/pages/e/_id.vue
@@ -1,7 +1,9 @@
 <template>
   <div class="flex flex-col justify-center">
+    <HoppSmartSpinner v-if="sharedRequestDetails.loading" />
+
     <div
-      v-if="invalidLink"
+      v-else-if="E.isLeft(sharedRequestDetails.data) || invalidLink"
       class="flex flex-1 flex-col items-center justify-center p-8"
     >
       <icon-lucide-alert-triangle class="svg-icons mb-2 opacity-75" />
@@ -12,30 +14,13 @@
         {{ t("error.invalid_embed_link") }}
       </p>
     </div>
+
     <Embeds
-      v-else-if="!invalidLink && tab"
+      v-else-if="tab"
       v-model:modelTab="tab"
       :properties="properties"
       :shared-request-i-d="sharedRequestID"
     />
-    <div v-else class="flex flex-1 flex-col items-center justify-center p-4">
-      <HoppSmartSpinner v-if="sharedRequestDetails.loading" />
-      <div
-        v-else-if="E.isLeft(sharedRequestDetails.data)"
-        class="flex flex-col items-center"
-      >
-        <icon-lucide-alert-triangle class="svg-icons mb-2 opacity-75" />
-        <h1 class="heading text-center">
-          {{ t("error.invalid_link") }}
-        </h1>
-        <p class="mt-2 text-center">
-          {{ t("error.invalid_embed_link") }}
-        </p>
-      </div>
-      <h1 v-if="E.isRight(sharedRequestDetails.data)" class="heading">
-        {{ t("state.loading") }}
-      </h1>
-    </div>
   </div>
 </template>