refactor: change default env name from 'global' to 'Global'

This commit is contained in:
liyasthomas
2021-08-18 10:44:58 +05:30
parent c949783698
commit 4f5de51104
4 changed files with 13 additions and 13 deletions

View File

@@ -10,7 +10,7 @@
class="input floating-input"
placeholder=" "
type="text"
:disabled="editingEnvironmentIndex === 'global'"
:disabled="editingEnvironmentIndex === 'Global'"
@keyup.enter="saveEnvironment"
/>
<label for="selectLabelEnvEdit">
@@ -114,7 +114,7 @@ export default defineComponent({
props: {
show: Boolean,
editingEnvironmentIndex: {
type: [Number, String] as PropType<number | "global" | null>,
type: [Number, String] as PropType<number | "Global" | null>,
default: null,
},
},
@@ -122,7 +122,7 @@ export default defineComponent({
const workingEnv = computed(() => {
if (props.editingEnvironmentIndex === null) return null
if (props.editingEnvironmentIndex === "global") {
if (props.editingEnvironmentIndex === "Global") {
return {
name: "Global",
variables: getGlobalVariables(),
@@ -180,7 +180,7 @@ export default defineComponent({
variables: this.vars,
}
if (this.editingEnvironmentIndex === "global")
if (this.editingEnvironmentIndex === "Global")
setGlobalEnvVariables(environmentUpdated.variables)
else updateEnvironment(this.editingEnvironmentIndex!, environmentUpdated)
this.hideModal()

View File

@@ -40,7 +40,7 @@
"
/>
<SmartItem
v-if="!(environmentIndex === 'global')"
v-if="!(environmentIndex === 'Global')"
icon="remove_circle_outline"
color="red"
:label="$t('delete')"
@@ -69,7 +69,7 @@ export default Vue.extend({
props: {
environment: { type: Object, default: () => {} },
environmentIndex: {
type: [Number, String] as PropType<number | "global">,
type: [Number, String] as PropType<number | "Global">,
default: null,
},
},
@@ -80,7 +80,7 @@ export default Vue.extend({
},
methods: {
removeEnvironment() {
if (this.environmentIndex !== "global")
if (this.environmentIndex !== "Global")
deleteEnvironment(this.environmentIndex)
this.$toast.error(this.$t("deleted").toString(), {
icon: "delete",

View File

@@ -76,10 +76,10 @@
/>
<div class="flex flex-col">
<EnvironmentsEnvironment
environment-index="global"
environment-index="Global"
:environment="globalEnvironment"
class="border-b border-dashed border-dividerLight"
@edit-environment="editEnvironment('global')"
@edit-environment="editEnvironment('Global')"
/>
<EnvironmentsEnvironment
v-for="(environment, index) in environments"
@@ -139,7 +139,7 @@ export default defineComponent({
showModalImportExport: false,
showModalAdd: false,
showModalEdit: false,
editingEnvironmentIndex: undefined as number | "global" | undefined,
editingEnvironmentIndex: undefined as number | "Global" | undefined,
}
},
methods: {
@@ -154,7 +154,7 @@ export default defineComponent({
displayModalImportExport(shouldDisplay: boolean) {
this.showModalImportExport = shouldDisplay
},
editEnvironment(environmentIndex: number | "global") {
editEnvironment(environmentIndex: number | "Global") {
this.$data.editingEnvironmentIndex = environmentIndex
this.displayModalEdit(true)
},