btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

fix: shared references on saveRequest causing overwrite fixes #1992

Browse Source
This commit is contained in:
Andrew Bastin
2021-12-03 16:27:18 +05:30
parent 38755bf3e3
commit 4d6d30c92b
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/hoppscotch-app/components/collections/SaveRequest.vue
View File

@@ -60,6 +60,7 @@
<script setup lang="ts"> <script setup lang="ts">
import { reactive, ref, watch } from "@nuxtjs/composition-api" import { reactive, ref, watch } from "@nuxtjs/composition-api"
import { HoppGQLRequest, isHoppRESTRequest } from "@hoppscotch/data" import { HoppGQLRequest, isHoppRESTRequest } from "@hoppscotch/data"
import cloneDeep from "lodash/cloneDeep"
import { import {
editGraphqlRequest, editGraphqlRequest,
editRESTRequest, editRESTRequest,
@@ -199,8 +200,12 @@ const saveRequestAs = async () => {
return return
} }
// Clone Deep because objects are shared by reference so updating
// just one bit will update other referenced shared instances
const requestUpdated = const requestUpdated =
props.mode === "rest" ? getRESTRequest() : getGQLSession().request props.mode === "rest"
? cloneDeep(getRESTRequest())
: cloneDeep(getGQLSession().request)
// // Filter out all REST file inputs // // Filter out all REST file inputs
// if (this.mode === "rest" && requestUpdated.bodyParams) { // if (this.mode === "rest" && requestUpdated.bodyParams) {