From 4adac4af380fa8ccd24901ba6596e36a0cb1f0b6 Mon Sep 17 00:00:00 2001 From: Nivedin <53208152+nivedin@users.noreply.github.com> Date: Mon, 28 Aug 2023 17:43:46 +0530 Subject: [PATCH] fix: inspections bugs (#3277) * fix: environment add bug in inspection * chore: add 127.0.0.1 in url inspection * chore: update browserextension inspection help url * fix: team env not showing bug in selector * chore: rework inspector systems to be reactive * chore: handling tab changes gracefully * refactor: move out url interceptor from the platform * chore: add view function in inspector service to get views into the list * fix: interceptors not kicking in on initial load * fix: don't show no internet connection error unless browser deems so * chore: fix tests --------- Co-authored-by: Andrew Bastin --- .../src/components/environments/Add.vue | 21 +- .../src/components/environments/Selector.vue | 271 +++++++++++++++--- .../src/components/environments/index.vue | 2 +- .../src/components/http/Headers.vue | 33 +-- .../src/components/http/Parameters.vue | 36 +-- .../src/components/http/Request.vue | 6 +- .../src/components/http/ResponseMeta.vue | 13 +- .../hoppscotch-common/src/helpers/rest/tab.ts | 5 +- .../hoppscotch-common/src/pages/index.vue | 18 +- .../hoppscotch-common/src/platform/index.ts | 2 + .../src/platform/inspectors.ts | 16 ++ .../__tests__/extension.inspector.spec.ts} | 60 ++-- .../std/inspections/extension.inspector.ts | 107 +++++++ .../menu/__tests__/environment.menu.spec.ts | 2 +- .../context-menu/menu/environment.menu.ts | 2 +- .../src/services/inspection/index.ts | 86 ++++-- .../__tests__/environment.inspector.spec.ts | 63 ++-- .../__tests__/header.inspector.spec.ts | 17 +- .../__tests__/response.inspector.spec.ts | 245 ++++++++++++++++ .../__tests__/response.interceptor.spec.ts | 151 ---------- .../inspectors/environment.inspector.ts | 115 ++++---- .../inspection/inspectors/header.inspector.ts | 81 +++--- .../inspectors/response.inspector.ts | 81 +++--- .../inspection/inspectors/url.inspector.ts | 96 ------- packages/hoppscotch-selfhost-web/src/main.ts | 4 + 25 files changed, 945 insertions(+), 588 deletions(-) create mode 100644 packages/hoppscotch-common/src/platform/inspectors.ts rename packages/hoppscotch-common/src/{services/inspection/inspectors/__tests__/url.inspector.spec.ts => platform/std/inspections/__tests__/extension.inspector.spec.ts} (56%) create mode 100644 packages/hoppscotch-common/src/platform/std/inspections/extension.inspector.ts create mode 100644 packages/hoppscotch-common/src/services/inspection/inspectors/__tests__/response.inspector.spec.ts delete mode 100644 packages/hoppscotch-common/src/services/inspection/inspectors/__tests__/response.interceptor.spec.ts delete mode 100644 packages/hoppscotch-common/src/services/inspection/inspectors/url.inspector.ts diff --git a/packages/hoppscotch-common/src/components/environments/Add.vue b/packages/hoppscotch-common/src/components/environments/Add.vue index 6d02f04f5..be4af410b 100644 --- a/packages/hoppscotch-common/src/components/environments/Add.vue +++ b/packages/hoppscotch-common/src/components/environments/Add.vue @@ -21,7 +21,12 @@ - +