From 4b4e6ca31a04528710e3b700bca67ed039ce8551 Mon Sep 17 00:00:00 2001 From: Igor Guastalla de Lima Date: Fri, 30 Aug 2019 09:11:30 -0300 Subject: [PATCH 1/2] Fix intersection button send again (removed validation inside forEach) --- pages/index.vue | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/pages/index.vue b/pages/index.vue index e524958ac..36e21f106 100644 --- a/pages/index.vue +++ b/pages/index.vue @@ -531,22 +531,15 @@ if (this[key]) this[key] = queries[key]; } }, - observeRequestButton: function () { - let isTheInitialIntersection = true; - const sendButtonElement = this.$refs.sendButton; - const requestElement = this.$refs.request.$el; - const observer = new IntersectionObserver((entries, observer) => { - entries.forEach(entry => { - if (entry.isIntersecting) { - if (!isTheInitialIntersection) { - sendButtonElement.classList.toggle('show'); - } else { - isTheInitialIntersection = false; - } - } - }); - }, {threshold: 1}); - observer.observe(requestElement); + observeRequestButton() { + const requestElement = this.$refs.request.$el; + const observer = new IntersectionObserver((entries, observer) => { + entries.forEach(entry => { + this.$refs.sendButton.classList.toggle('show'); + }); + }, { threshold: 1 }); + + observer.observe(requestElement); } }, created() { From daa491cd176d425246778c6d3a74bcd7c8094b55 Mon Sep 17 00:00:00 2001 From: Igor Guastalla de Lima Date: Fri, 30 Aug 2019 09:36:16 -0300 Subject: [PATCH 2/2] Change again the way of showing by adding and clearing the className --- pages/index.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pages/index.vue b/pages/index.vue index 36e21f106..4ad32d04e 100644 --- a/pages/index.vue +++ b/pages/index.vue @@ -533,9 +533,10 @@ }, observeRequestButton() { const requestElement = this.$refs.request.$el; + const sendButton = this.$refs.sendButton; const observer = new IntersectionObserver((entries, observer) => { entries.forEach(entry => { - this.$refs.sendButton.classList.toggle('show'); + sendButton.className = entry.isIntersecting ? '' : 'show'; }); }, { threshold: 1 });