From 4ad4bad295de2322d3861332be97846c93fe98dd Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 23 Jan 2020 14:09:36 +0530 Subject: [PATCH 1/7] fix: validation for empty collection names --- components/collections/addCollection.vue | 3 +++ 1 file changed, 3 insertions(+) diff --git a/components/collections/addCollection.vue b/components/collections/addCollection.vue index 2789a52d7..7437e7999 100644 --- a/components/collections/addCollection.vue +++ b/components/collections/addCollection.vue @@ -56,6 +56,9 @@ export default { }, methods: { addNewCollection() { + if (this.$data.name !== undefined) { + return; + } this.$store.commit("postwoman/addNewCollection", { name: this.$data.name }); From 5481c28e4bbe84ca1004526c00e514b5718a8b0a Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 23 Jan 2020 14:10:26 +0530 Subject: [PATCH 2/7] refactor: use shorthand version --- components/collections/addCollection.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/collections/addCollection.vue b/components/collections/addCollection.vue index 7437e7999..9f0cc8139 100644 --- a/components/collections/addCollection.vue +++ b/components/collections/addCollection.vue @@ -56,7 +56,7 @@ export default { }, methods: { addNewCollection() { - if (this.$data.name !== undefined) { + if (!this.$data.name) { return; } this.$store.commit("postwoman/addNewCollection", { From c3ecf98b626bf82f342c610c90cc69e278c836ca Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 23 Jan 2020 14:11:04 +0530 Subject: [PATCH 3/7] feat: show warning alert --- components/collections/addCollection.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/components/collections/addCollection.vue b/components/collections/addCollection.vue index 9f0cc8139..8a2c86fc7 100644 --- a/components/collections/addCollection.vue +++ b/components/collections/addCollection.vue @@ -57,6 +57,7 @@ export default { methods: { addNewCollection() { if (!this.$data.name) { + alert('Please provide a name') return; } this.$store.commit("postwoman/addNewCollection", { From 9b8936f53c8b132ba4e901b1658d2e21cfab9a17 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 23 Jan 2020 14:12:04 +0530 Subject: [PATCH 4/7] feat: switch to toast --- components/collections/addCollection.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/collections/addCollection.vue b/components/collections/addCollection.vue index 8a2c86fc7..0348c87a6 100644 --- a/components/collections/addCollection.vue +++ b/components/collections/addCollection.vue @@ -57,7 +57,7 @@ export default { methods: { addNewCollection() { if (!this.$data.name) { - alert('Please provide a name') + this.$toast.info('Please provide a name') return; } this.$store.commit("postwoman/addNewCollection", { From b0c22a2b2d96e8378599a74774c742edd56291d5 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 23 Jan 2020 14:52:52 +0530 Subject: [PATCH 5/7] chore: validate edit collection activity for empty names --- components/collections/editCollection.vue | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/components/collections/editCollection.vue b/components/collections/editCollection.vue index 4021557fe..98c9154be 100644 --- a/components/collections/editCollection.vue +++ b/components/collections/editCollection.vue @@ -59,6 +59,10 @@ export default { }, methods: { saveCollection() { + if (!this.$data.name) { + this.$toast.info('Please provide a valid name for the collection'); + return; + } const collectionUpdated = { ...this.$props.editingCollection, name: this.$data.name From f132de8dbbd956e1027b53d3ded8008c6ae08095 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 23 Jan 2020 14:57:44 +0530 Subject: [PATCH 6/7] chore: validate edit collection activity for duplicate collection --- store/postwoman.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/store/postwoman.js b/store/postwoman.js index 61712fb65..b7ae1258d 100644 --- a/store/postwoman.js +++ b/store/postwoman.js @@ -132,6 +132,12 @@ export const mutations = { editCollection({ collections }, payload) { const { collection, collectionIndex } = payload; + const { name } = collection + const duplicateCollection = collections.some(item => item.name === name) + if (duplicateCollection) { + this.$toast.info('Duplicate collection'); + return; + } collections[collectionIndex] = collection; }, From 7d003cefd76dc62e6560674cc9898061cb569e00 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Thu, 23 Jan 2020 14:59:21 +0530 Subject: [PATCH 7/7] chore: rephrase warning message --- components/collections/addCollection.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/collections/addCollection.vue b/components/collections/addCollection.vue index 0348c87a6..c39b7b257 100644 --- a/components/collections/addCollection.vue +++ b/components/collections/addCollection.vue @@ -57,7 +57,7 @@ export default { methods: { addNewCollection() { if (!this.$data.name) { - this.$toast.info('Please provide a name') + this.$toast.info('Please provide a valid name for the collection') return; } this.$store.commit("postwoman/addNewCollection", {