refactor: allow banner service to hold multiple banners and display the banner with the highest score (#3556)

This commit is contained in:
Joel Jacob Stephen
2023-11-17 20:31:34 +05:30
committed by GitHub
parent a3aa9b68fc
commit 24ae090916
4 changed files with 112 additions and 48 deletions

View File

@@ -8,10 +8,10 @@
<span class="text-white">
<span v-if="banner.alternateText" class="md:hidden">
{{ banner.alternateText }}
{{ banner.alternateText(t) }}
</span>
<span class="<md:hidden">
{{ banner.text }}
<span :class="banner.alternateText ? '<md:hidden' : ''">
{{ banner.text(t) }}
</span>
</span>
</div>
@@ -19,8 +19,8 @@
<script setup lang="ts">
import { computed } from "vue"
import { BannerContent, BannerType } from "~/services/banner.service"
import { useI18n } from "@composables/i18n"
import IconAlertCircle from "~icons/lucide/alert-circle"
import IconAlertTriangle from "~icons/lucide/alert-triangle"
@@ -30,6 +30,8 @@ const props = defineProps<{
banner: BannerContent
}>()
const t = useI18n()
const ariaRoles: Record<BannerType, string> = {
error: "alert",
warning: "status",