From 1d93745a4ee9cb4eb7387f6b94def0e02802816b Mon Sep 17 00:00:00 2001 From: Mir Arif Hasan Date: Tue, 11 Jul 2023 17:37:47 +0600 Subject: [PATCH] chore: improved code readability --- .../src/team-invitation/team-invitation.service.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts b/packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts index 3b3e2efd7..ecb13f4e4 100644 --- a/packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts +++ b/packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts @@ -115,21 +115,21 @@ export class TeamInvitationService { if (!team) return E.left(TEAM_INVALID_ID); // invitation creator should be a TeamMember - const teamMemberCreator = await this.teamService.getTeamMember( + const isTeamMember = await this.teamService.getTeamMember( team.id, creator.uid, ); - if (!teamMemberCreator) return E.left(TEAM_MEMBER_NOT_FOUND); + if (!isTeamMember) return E.left(TEAM_MEMBER_NOT_FOUND); // Checking to see if the invitee is already part of the team or not const inviteeUser = await this.userService.findUserByEmail(inviteeEmail); if (O.isSome(inviteeUser)) { // invitee should not already a member - const teamMemberInvitee = await this.teamService.getTeamMember( + const isTeamMember = await this.teamService.getTeamMember( team.id, inviteeUser.value.uid, ); - if (teamMemberInvitee) return E.left(TEAM_INVITE_ALREADY_MEMBER); + if (isTeamMember) return E.left(TEAM_INVITE_ALREADY_MEMBER); } // check invitee already invited earlier or not