btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

fix: scrollbar appearing on digest auth input fields and other improvements (#4492)

Browse Source 
Co-authored-by: jamesgeorge007 <25279263+jamesgeorge007@users.noreply.github.com>
This commit is contained in:
Anwarul Islam
2024-10-29 21:05:13 +06:00
committed by GitHub
parent 108315d1b4
commit 1236e6b719
4 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/hoppscotch-cli/src/utils/request.ts
View File

@@ -240,7 +240,6 @@ export const processRequest =
// Updating report for errors & current result // Updating report for errors & current result
report.errors.push(preRequestRes.left); report.errors.push(preRequestRes.left);
console.error(`Report result is `, report.result);
report.result = report.result; report.result = report.result;
} else { } else {
// Updating effective-request and consuming updated envs after pre-request script execution // Updating effective-request and consuming updated envs after pre-request script execution

2
packages/hoppscotch-common/src/components/http/Authorization.vue
View File

@@ -272,8 +272,6 @@ const selectDigestAuthType = () => {
algorithm = "MD5", algorithm = "MD5",
} = auth.value as HoppRESTAuthDigest } = auth.value as HoppRESTAuthDigest
console.error(`Auth is `, auth.value)
auth.value = { auth.value = {
...auth.value, ...auth.value,
authType: "digest", authType: "digest",

12
packages/hoppscotch-common/src/components/http/authorization/Digest.vue
View File

@@ -36,8 +36,7 @@
:auto-complete-env="true" :auto-complete-env="true"
:placeholder="`${t( :placeholder="`${t(
'authorization.digest.realm' 'authorization.digest.realm'
)} (e.g. testrealm@example.com) )} (e.g. testrealm@example.com)`"
`"
:envs="envs" :envs="envs"
/> />
</div> </div>
@@ -98,8 +97,7 @@
<SmartEnvInput <SmartEnvInput
v-model="auth.qop" v-model="auth.qop"
:auto-complete-env="true" :auto-complete-env="true"
:placeholder="`${t('authorization.digest.qop')} (e.g. auth-int) :placeholder="`${t('authorization.digest.qop')} (e.g. auth-int)`"
`"
:envs="envs" :envs="envs"
/> />
</div> </div>
@@ -108,8 +106,7 @@
<SmartEnvInput <SmartEnvInput
v-model="auth.nc" v-model="auth.nc"
:auto-complete-env="true" :auto-complete-env="true"
:placeholder="`${t('authorization.digest.nonce_count')} (e.g. 00000001) :placeholder="`${t('authorization.digest.nonce_count')} (e.g. 00000001)`"
`"
:envs="envs" :envs="envs"
/> />
</div> </div>
@@ -118,8 +115,7 @@
<SmartEnvInput <SmartEnvInput
v-model="auth.cnonce" v-model="auth.cnonce"
:auto-complete-env="true" :auto-complete-env="true"
:placeholder="`${t('authorization.digest.client_nonce')} (e.g. Oa4f113b) :placeholder="`${t('authorization.digest.client_nonce')} (e.g. Oa4f113b)`"
`"
:envs="envs" :envs="envs"
/> />
</div> </div>

6
packages/hoppscotch-common/src/services/inspection/inspectors/authorization.inspector.ts
View File

@@ -6,6 +6,7 @@ import { Service } from "dioc"
import { computed, markRaw, Ref } from "vue" import { computed, markRaw, Ref } from "vue"
import { getI18n } from "~/modules/i18n" import { getI18n } from "~/modules/i18n"
import { platform } from "~/platform"
import { AgentInterceptorService } from "~/platform/std/interceptors/agent" import { AgentInterceptorService } from "~/platform/std/interceptors/agent"
import { InterceptorService } from "~/services/interceptor.service" import { InterceptorService } from "~/services/interceptor.service"
import { RESTTabService } from "~/services/tab/rest" import { RESTTabService } from "~/services/tab/rest"
@@ -74,9 +75,12 @@ export class AuthorizationInspectorService
const results: InspectorResult[] = [] const results: InspectorResult[] = []
// `Agent` interceptor is recommended while using Digest Auth // `Agent` interceptor is recommended while using Digest Auth
// TODO: Better check to detect the platform
// Interceptor check only applies to the browser platform
const isUnsupportedInterceptor = const isUnsupportedInterceptor =
platform.interceptors.default === "browser" &&
this.interceptorService.currentInterceptorID.value !== this.interceptorService.currentInterceptorID.value !==
this.agentService.interceptorID this.agentService.interceptorID
const resolvedAuthType = this.resolveAuthType(auth) const resolvedAuthType = this.resolveAuthType(auth)