btwedutech/hoppscotch
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

chore: improved command labels and icons (#3295)

Browse Source 
* chore: improved command labels and icons

* chore: fix tests

---------

Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
This commit is contained in:
Liyas Thomas
2023-08-28 18:15:00 +05:30
committed by GitHub
parent 8499ac7fec
commit 0eacd6763b
5 changed files with 72 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/hoppscotch-common/src/services/spotlight/searchers/tab.searcher.ts
View File

@@ -15,7 +15,10 @@ import {
currentTabID,
getActiveTabs,
} from "~/helpers/rest/tab"
import IconWindow from "~icons/lucide/app-window"
import IconCopy from "~icons/lucide/copy"
import IconCopyPlus from "~icons/lucide/copy-plus"
import IconXCircle from "~icons/lucide/x-circle"
import IconXSquare from "~icons/lucide/x-square"
import { invokeAction } from "~/helpers/actions"
type Doc = {
@@ -50,29 +53,29 @@ export class TabSpotlightSearcherService extends StaticSpotlightSearcherService<
duplicate_tab: {
text: this.t("spotlight.tab.duplicate"),
alternates: ["tab", "duplicate", "duplicate tab"],
icon: markRaw(IconWindow),
icon: markRaw(IconCopy),
excludeFromSearch: computed(() => !this.showAction.value),
},
close_current_tab: {
text: this.t("spotlight.tab.close_current"),
alternates: ["tab", "close", "close tab"],
icon: markRaw(IconWindow),
icon: markRaw(IconXCircle),
excludeFromSearch: computed(
() => !this.showAction.value ?? getActiveTabs().value.length === 1
() => !this.showAction.value || getActiveTabs().value.length === 1
),
},
close_other_tabs: {
text: this.t("spotlight.tab.close_others"),
alternates: ["tab", "close", "close all"],
icon: markRaw(IconWindow),
icon: markRaw(IconXSquare),
excludeFromSearch: computed(
() => !this.showAction.value ?? getActiveTabs().value.length < 2
() => !this.showAction.value || getActiveTabs().value.length < 2
),
},
open_new_tab: {
text: this.t("spotlight.tab.new_tab"),
alternates: ["tab", "new", "open tab"],
icon: markRaw(IconWindow),
icon: markRaw(IconCopyPlus),
excludeFromSearch: computed(() => !this.showAction.value),
},
})